From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Eric Paris <eparis@redhat.com>,
linux-kernel@vger.kernel.org, jengelh@medozas.de,
davem@davemloft.net
Subject: Re: [PATCH] types.h: define __aligned_u64 and expose to userspace
Date: Fri, 15 Oct 2010 02:03:10 -0700 [thread overview]
Message-ID: <20101015020310.5a4eddbd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101015084311.GA25620@basil.fritz.box>
On Fri, 15 Oct 2010 10:43:11 +0200 Andi Kleen <andi@firstfloor.org> wrote:
> On Fri, Oct 15, 2010 at 12:24:55AM -0400, Eric Paris wrote:
> > We currently have a kernel internal type called aligned_u64 which aligns
> > __u64's on 8 bytes boundaries even on systems which would normally align
> > them on 4 byte boundaries. This patch creates a new type __aligned_u64
> > which does the same thing but which is exposed to userspace rather than
> > being kernel internal.
> >
> > Based-on-patch-by: Andreas Gruenbacher <agruen@suse.de>
> > Signed-off-by: Eric Paris <eparis@redhat.com>
>
> Acked-by: Andi Kleen <ak@linux.intel.com>
>
> but only if you:
>
> > +/* this is a special 64bit data type that is 8-byte aligned */
>
> Expand this comment a bit that that using this type as a
> replacement for u64 is recommended
> for any user visible 64bit value in a structure and that it
> avoids problem with the compat layer on x86-64.
>
Well yes, I was actually about to write that comment. But it should
describe the compat problems fully?
next prev parent reply other threads:[~2010-10-15 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 4:24 [PATCH] types.h: define __aligned_u64 and expose to userspace Eric Paris
2010-10-15 8:43 ` Andi Kleen
2010-10-15 9:03 ` Andrew Morton [this message]
2010-10-15 8:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015020310.5a4eddbd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox