From: Alessandro Zummo <a.zummo@towertech.it>
To: achew@nvidia.com
Cc: jmayo@nvidia.com, olof@lixom.net, greg@kroah.com,
mcuos.com@gmail.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, rtc-linux@googlegroups.com,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/1 V2] rtc: Add real-time clock driver for Tegra.
Date: Fri, 15 Oct 2010 10:03:59 +0200 [thread overview]
Message-ID: <20101015100359.7860028e@linux.lan.towertech.it> (raw)
In-Reply-To: <1287089791-25673-1-git-send-email-achew@nvidia.com>
On Thu, 14 Oct 2010 13:56:31 -0700
achew@nvidia.com wrote:
> + info->rtc_base = ioremap(res->start, res->end - res->start + 1);
please use resource_size()
> +MODULE_DESCRIPTION("driver for Tegra internal RTC");
> +MODULE_LICENSE("GPL");
missing MODULE_AUTHOR with email address
pending those corrections,
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2010-10-15 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 20:56 [PATCH 1/1 V2] rtc: Add real-time clock driver for Tegra achew
2010-10-15 8:03 ` Alessandro Zummo [this message]
2010-10-15 22:12 ` Erik Gilling
2010-10-15 22:35 ` Greg KH
2010-10-15 22:55 ` Erik Gilling
2010-10-15 22:57 ` Andrew Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015100359.7860028e@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=achew@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jmayo@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=olof@lixom.net \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox