From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755132Ab0JOLL5 (ORCPT ); Fri, 15 Oct 2010 07:11:57 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:65370 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753135Ab0JOLLz (ORCPT ); Fri, 15 Oct 2010 07:11:55 -0400 From: Arnd Bergmann To: Akinobu Mita Subject: Re: [PATCH 03/22] s390: introduce little endian bitops Date: Fri, 15 Oct 2010 13:12:30 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.35-16-generic; KDE/4.3.2; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Christoph Hellwig , Andrew Morton , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, linux-s390@vger.kernel.org References: <1287135981-17604-1-git-send-email-akinobu.mita@gmail.com> <1287135981-17604-4-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1287135981-17604-4-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201010151312.30843.arnd@arndb.de> X-Provags-ID: V02:K0:mnAFtREpeBX+IK3Awk0kdo8lZi7glOMijmwDaEtaxdO ZRHt7KoS6a9y9wV/daKDj5b/SS2D3bnCM7jMStl1+d5iY6BZLB lXqb8DnLjQVyXiY3XJwnTO7GYgfSFw2AuKuJKsGHhr6QQm2O65 eke1KMc+wgtqnYprFWVrROuWobct/oyFNzW86k8/sQePDG8KKP UHdr4azx4WrBQk5jk9GAg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 15 October 2010, Akinobu Mita wrote: > +#define __set_le_bit(nr, addr) \ > + __set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) > +#define __clear_le_bit(nr, addr) \ > + __clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) > +#define __test_and_set_le_bit(nr, addr) \ > + __test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) > +#define test_and_set_le_bit(lock, nr, addr) \ > + test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) > +#define __test_and_clear_le_bit(nr, addr) \ > + __test_and_clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) > +#define test_and_clear_le_bit(lock, nr, addr) \ > + test_and_clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) > +#define test_le_bit(nr, addr) \ > + test_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) The test_and_clear_le_bit and test_and_set_le_bit calling conventions are a little surprising here. I would not pass the lock argument here but leave that to the ext2 wrapper: #define test_and_set_le_bit(nr, addr) \ test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) #define test_and_clear_le_bit(nr, addr) \ test_and_clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr)) #define ext2_set_bit_atomic(lock, nr, addr) \ test_and_set_le_bit((nr), (unsigned long *)(addr)) #define ext2_clear_bit_atomic(lock, nr, addr) \ test_and_clear_le_bit((nr), (unsigned long *)(addr)) Same thing on arm and m68k. Arnd