Re: [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector

Guenter Roeck
2010-10-16T01:59:10Z

On Tue, Oct 12, 2010 at 09:15:16PM -0400, Guenter Roeck wrote:
> This patch adds support for PCA9541, an I2C Bus Master Selector.
> The driver is modeled as single channel I2C Multiplexer to be able to utilize
> the I2C multiplexer framework.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> Reviewed-by: Tom Grennan <tom.grennan@ericsson.com>
> ---
> v2 changes:
> - Added more detailed description and reasoning why the driver was implemented
> as single-channel multiplexer.
> - Modified arbitration algorithm, since access to i2c masters from interrupt
> level is not a good idea. Instead of using hrtimers and handling arbitration
> in interrupt, handle it from select_chan and either delay for short retry
> periods or sleep for long (millisecond) periods.
>
> drivers/i2c/muxes/Kconfig | 10 +
> drivers/i2c/muxes/Makefile | 1 +
> drivers/i2c/muxes/pca9541.c | 397 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 408 insertions(+), 0 deletions(-)
> create mode 100644 drivers/i2c/muxes/pca9541.c
>
Any comments / thoughts / feedback ?

Thanks,
Guenter