Re: [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector

Jean Delvare
2010-10-19T21:49:42Z

On Tue, 19 Oct 2010 13:50:53 -0700, Guenter Roeck wrote:
> Hi Jean,
>
> On Tue, 2010-10-19 at 13:06 -0400, Jean Delvare wrote:
> [ ... ]
> > > +
> > > +/*
> > > + * I2C init/probing/exit functions
> > > + */
> > > +static int __devinit pca9541_probe(struct i2c_client *client,
> > > + const struct i2c_device_id *id)
> >
> > The use of __devinit and __devexit isn't recommended for i2c drivers.
> > If your driver is built into the kernel but the underlying i2c bus
> > driver is build as a module, you're in trouble.
> >
> I don't mind changing this, but ... the code is copied from pca954x.c,
> which also uses __devinit and __devexit for the same functions. Wouldn't
> that be a problem there as well ? Or am I missing something ?

You're right, this should be fixed. I take patches ;)

--
Jean Delvare