From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Robin Holt <holt@sgi.com>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: ftrace does not work on cpus > 999.
Date: Sat, 16 Oct 2010 18:16:27 +0200 [thread overview]
Message-ID: <20101016161627.GA3567@elte.hu> (raw)
In-Reply-To: <1287242272.16971.53.camel@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 2010-10-16 at 16:45 +0200, Frederic Weisbecker wrote:
>
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 9ec59f5..3565f9e 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -3999,7 +3999,7 @@ static void tracing_init_debugfs_percpu(long cpu)
> > /* strlen(cpu) + MAX(log10(cpu)) + '\0' */
> > char cpu_dir[7];
> >
> > - if (cpu > 999 || cpu < 0)
> > + if (cpu < 0)
> > return;
> >
> > sprintf(cpu_dir, "cpu%ld", cpu);
>
> You need to change the size of cpu_dir, otherwise this will overflow.
If you change it to 30 that ought to be enough, as long as cpu_id's fit
into u64. (I think we wont overflow that in my lifetime.)
> The other case is to dynamically allocate cpu_dir.
Please tell me that is a joke ...
Ingo
next prev parent reply other threads:[~2010-10-16 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 13:15 ftrace does not work on cpus > 999 Robin Holt
2010-10-16 14:45 ` Frederic Weisbecker
2010-10-16 15:17 ` Steven Rostedt
2010-10-16 16:16 ` Ingo Molnar [this message]
2010-10-16 16:32 ` Steven Rostedt
2010-10-16 16:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101016161627.GA3567@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox