From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752019Ab0JPQhE (ORCPT <rfc822;w@1wt.eu>);
	Sat, 16 Oct 2010 12:37:04 -0400
Received: from mail-ew0-f46.google.com ([209.85.215.46]:50086 "EHLO
	mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751497Ab0JPQhB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 16 Oct 2010 12:37:01 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=PINkh3GCIiI2vYneAGljl10RTJX7MGzHwFZ5EYu2clDr0cBhxgmPRh7P5eUmwKsouB
         g32IIO1bkURu+7+HqOKixB3D7xt/sprjB8qCQ6piQIcaqhV0KY2DGJdrItCOYkYl8Rtq
         DWOhV7OjkSgWBqaVX55AQ63zvdAKS0FiXgrCw=
Date: Sat, 16 Oct 2010 20:36:57 +0400
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Don Zickus <dzickus@redhat.com>, Andi Kleen <andi@firstfloor.org>,
        mingo@elte.hu, fweisbec@gmail.com, robert.richter@amd.com,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC] arch generic way to trigger unknown NMIs
Message-ID: <20101016163657.GB6763@lenovo>
References: <20101007030807.GA4076@redhat.com> <20101007072641.GE5010@basil.fritz.box> <20101007140112.GN10663@redhat.com> <alpine.LFD.2.00.1010072342170.15889@eddie.linux-mips.org> <20101010202357.GA28938@lenovo> <alpine.LFD.2.00.1010160822250.15889@eddie.linux-mips.org> <20101016153229.GA6763@lenovo> <alpine.LFD.2.00.1010161710290.15889@eddie.linux-mips.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LFD.2.00.1010161710290.15889@eddie.linux-mips.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 16, 2010 at 05:15:16PM +0100, Maciej W. Rozycki wrote:
> On Sat, 16 Oct 2010, Cyrill Gorcunov wrote:
> 
> >  Hi Maciej, the send_IPI_self could be modified to send NMI (at moment it
> > uses self shortcut with fixed delivery mode). The question is rather if
> > we need it without a real caller yet. When Don's patch gets merged we
> > will have a real caller then and could update send_IPI_self to support
> > NMI delivery mode. Something like that :)
> 
>  Sounds backwards to me.  My understanding is a need has just arisen, so 
> why not:
> 
> 1. Update send_IPI_self().
> 
> 2. Add code that makes use of the new functionality.
> 
> 3. Submit all the changes as self-contained patches in a single series to 
>    be applied at the same time.
> 
> ?  That's what I'd imagine the most natural way of doing this would be.
> 
>   Maciej
> 

 Well, Maciej I believe the problem is not in modifying send_IPI_self
but rather _how_ to make it more natural and do not introduce overhead.
apic code is already weird enough :) Need to think.

(
 btw, we will have to add additional flag which would check for NMI
 being generated by "NMI-tester" and make a second apic write to
 ICR to deassert level line, ie it could be something like

  apic->send_IPI_self(NMI_VECTOR)       ; with asserts level
   default_do_nmi()                     ; check for NMI being sent for testing purpose
     apic->send_IPI_self(NMI_VECTOR)    ; with deasserts level

 iirc apic itself doesn't deassert nmi line on message with
 nmi deliver mode arrival
 )

  Cyrill