Re: [PATCH 19/19] fs: do not assign default i_ino in new_inode

Eric Dumazet
2010-10-16T09:09:21Z

Le samedi 16 octobre 2010 à 19:14 +1100, Dave Chinner a écrit :
> From: Christoph Hellwig <hch@lst.de>
>
> Instead of always assigning an increasing inode number in new_inode
> move the call to assign it into those callers that actually need it.
> For now callers that need it is estimated conservatively, that is
> the call is added to all filesystems that do not assign an i_ino
> by themselves. For a few more filesystems we can avoid assigning
> any inode number given that they aren't user visible, and for others
> it could be done lazily when an inode number is actually needed,
> but that's left for later patches.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

I wonder if adding a flag in super_block to explicitely say :

"I dont need new_inode() allocates a i_ino for my new inode, because
I'll take care of this myself later"

would be safer, permiting each fs maintainer to assert the flag instead
of a single patch.