Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor inode disposal

Nick Piggin
2010-10-17T02:49:33Z

On Sat, Oct 16, 2010 at 09:30:47PM -0400, Christoph Hellwig wrote:
> > * inode->i_lock is *always* the innermost lock.
> > *
> > + * inode->i_lock is *always* the innermost lock.
> > + *
>
> No need to repeat, we got it..

Except that I didn't see where you fixed all the places where it is
*not* the innermost lock. Like for example places that take dcache_lock
inside i_lock.

Really, the assertions that my series is causing the world to end
because it makes i_lock no longer the innermost lock (not that it is
anyway) etc. is just not constructive in the slightest.

A lock is a lock. If we take another lock inside it, it is not an
innermost lock. If we do it properly and don't introduce deadlocks, it
is not a bug.