From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932539Ab0JROj3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Oct 2010 10:39:29 -0400
Received: from thunk.org ([69.25.196.29]:36518 "EHLO thunker.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756509Ab0JROjZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Oct 2010 10:39:25 -0400
Date: Mon, 18 Oct 2010 10:39:35 -0400
From: "Ted Ts'o" <tytso@mit.edu>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Joe Perches <joe@perches.com>,
        Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels
Message-ID: <20101018143935.GA4120@thunk.org>
Mail-Followup-To: Ted Ts'o <tytso@mit.edu>,
	Mike Frysinger <vapier@gentoo.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
References: <1287302737-3507-1-git-send-email-vapier@gentoo.org>
 <1287303678.20968.37.camel@Joe-Laptop>
 <AANLkTimmSRS3eVsW4EZUxnE_rfjeqmmgGnjtWbn3J_nY@mail.gmail.com>
 <1287310889.1998.153.camel@laptop>
 <1287334498.20968.53.camel@Joe-Laptop>
 <1287343839.1998.699.camel@laptop>
 <AANLkTikaxf-Fh9qUxsXNO5=r+SoxbzYXvCjFcHQLcXjy@mail.gmail.com>
 <1287345710.1998.735.camel@laptop>
 <AANLkTimixEGQTYrM7ShodtKeC97e0uPNRhWQn8F+-Nui@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTimixEGQTYrM7ShodtKeC97e0uPNRhWQn8F+-Nui@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 17, 2010 at 04:26:25PM -0400, Mike Frysinger wrote:
> On Sun, Oct 17, 2010 at 16:01, Peter Zijlstra wrote:
> > On Sun, 2010-10-17 at 15:49 -0400, Mike Frysinger wrote:
> >> sounds like a good reason to shut up the new unintended warnings
> >
> > I'm failing to see any logic there, old code doesn't generate warnings,
> > its new code that would, and new code should never have any whitespace
> > in front of labels.
> 
> it's a waste of time to massage code to one person's opinion

+1

It's not in CondingStyle; I prefer to outdent labels by one tab stop:

			if (!page_has_buffers(page)) {
				if (block_prepare_write(page, 0, len,
						noalloc_get_block_write)) {
				redirty_page:
					redirty_page_for_writepage(mpd->wbc,
								   page);
					unlock_page(page);
					continue;
				}
				commit_write = 1;
			}

... and I hereby serve notice that if I start getting trash patches
from newbies about checkpatch.pl warning/errors for stuff like this,
I'll will (a) toast them and tell them they are wasting their time
with checkpatch.pl, and (b) agitate strongly for the removal of such
trash checkpatch.pl or for checkpatch.pl as a whole, as being harmful
to kernel development.

						- Ted