From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757618Ab0JRScs (ORCPT ); Mon, 18 Oct 2010 14:32:48 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:35176 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754954Ab0JRSci convert rfc822-to-8bit (ORCPT ); Mon, 18 Oct 2010 14:32:38 -0400 Date: Mon, 18 Oct 2010 14:32:23 -0200 From: "Gustavo F. Padovan" To: Harvey Harrison Cc: Mike Frysinger , linux-bluetooth@vger.kernel.org, Marcel Holtmann , uclinux-dist-devel@blackfin.uclinux.org, linux-kernel@vger.kernel.org, Andrew Morton , steven miao Subject: Re: [PATCH] bluetooth: fix unaligned access to l2cap conf data Message-ID: <20101018163223.GC2468@vigoh> References: <1287268187-9628-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Harvey, * Harvey Harrison [2010-10-18 11:17:28 -0700]: > On Sat, Oct 16, 2010 at 3:29 PM, Mike Frysinger wrote: > > From: steven miao > > > > > >        case 2: > > -               *((__le16 *) opt->val) = cpu_to_le16(val); > > +               put_unaligned_le16(cpu_to_le16(val), opt->val); > >                break; > > > > I think you wanted: > put_unaligned_le16(val, opt->val); I fixed that in the tree. Thanks for the report. -- Gustavo F. Padovan ProFUSION embedded systems - http://profusion.mobi