From: Jarod Wilson <jarod@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: drivers/media/IR/imon.c: Use pr_err instead of err
Date: Mon, 18 Oct 2010 16:27:34 -0400 [thread overview]
Message-ID: <20101018202734.GA13401@redhat.com> (raw)
In-Reply-To: <1277018446.1548.66.camel@Joe-Laptop.home>
On Sun, Jun 20, 2010 at 07:20:46AM -0000, Joe Perches wrote:
> Use the standard error logging mechanisms.
> Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__
> Remove __func__ from err calls, add '\n', rename to pr_err
>
> Signed-off-by: Joe Perches <joe@perches.com>
Since I haven't got around to actually looking into using dev_foo bits
instead where appropriate, lets just go ahead with this patch and if/when
I get around to it later, I can switch things to dev_foo where possible.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2010-10-18 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 7:20 [PATCH] drivers/media/IR/imon.c: Use pr_err instead of err Joe Perches
2010-06-20 15:58 ` Jarod Wilson
2010-06-20 16:53 ` Joe Perches
2010-06-20 17:34 ` Jarod Wilson
2010-10-18 20:27 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018202734.GA13401@redhat.com \
--to=jarod@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox