From: Frederic Weisbecker <fweisbec@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>, David Rientjes <rientjes@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] x86: Cleanup TIF value gaps in shift range
Date: Mon, 18 Oct 2010 23:10:31 +0200 [thread overview]
Message-ID: <20101018211028.GA5370@nowhere> (raw)
In-Reply-To: <4CBCB28A.9010602@zytor.com>
On Mon, Oct 18, 2010 at 01:48:10PM -0700, H. Peter Anvin wrote:
> On 10/18/2010 01:35 PM, Frederic Weisbecker wrote:
> > 9, 19 and 26 values are missing from the TIF shift range, probably
> > due to flags that were removed by the past. Now repack the range
> > so that we can quickly retrieve the remaining free shift slots.
> >
> > But take care of keeping the seperation between high and low bits
> > as some masks are created on top of this boundary.
> >
>
> What is the point of this? All it seems is that it would make stupid
> debugging mistakes possible because someone looks at the values from the
> wrong kernel.
>
> Feel free to put comments in:
>
> /* 9 - unused - was TIF_xxx */
>
> ... but I think gratuitous compaction is a really bad idea.
>
> Nacked-by: H. Peter Anvin <hpa@zytor.com>
I just felt the current state was messy. But I understand your reasons,
just forget those patches.
Thanks.
prev parent reply other threads:[~2010-10-18 21:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 20:35 [PATCH 1/2] x86: Cleanup TIF value gaps in shift range Frederic Weisbecker
2010-10-18 20:35 ` [PATCH 2/2] x86: Remove stale TIF_DEBUG Frederic Weisbecker
2010-10-18 22:12 ` [PATCH v2] " Frederic Weisbecker
2010-10-18 20:47 ` [PATCH 1/2] x86: Cleanup TIF value gaps in shift range David Rientjes
2010-10-18 21:23 ` Thomas Gleixner
2010-10-18 21:28 ` H. Peter Anvin
2010-10-18 21:36 ` David Rientjes
2010-10-18 21:43 ` H. Peter Anvin
2010-10-18 22:00 ` David Rientjes
2010-10-18 23:23 ` H. Peter Anvin
2010-10-18 21:30 ` David Rientjes
2010-10-18 20:48 ` H. Peter Anvin
2010-10-18 21:10 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018211028.GA5370@nowhere \
--to=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox