From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757860Ab0JRXME (ORCPT ); Mon, 18 Oct 2010 19:12:04 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:62662 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755900Ab0JRXMC (ORCPT ); Mon, 18 Oct 2010 19:12:02 -0400 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 67.188.36.105 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18JAJbEFTffrIYBlbnXKN8V Date: Mon, 18 Oct 2010 16:11:47 -0700 From: Tony Lindgren To: Evgeny Kuznetsov Cc: "ext Varadarajan, Charulatha" , linux-omap@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Balbi, Felipe" , "linux@arm.linux.org.uk" , "khilman@deeprootsystems.com" , "akpm@linux-foundation.org" , "tero.kristo@nokia.com" Subject: Re: [PATCHv2 1/1] omap: Ptr "isr_reg" tracked as NULL was dereferenced Message-ID: <20101018231147.GK13341@atomide.com> References: <7bb69801f49283c3bde78aa008c15308ac8a5fbf.1286961160.git.EXT-Eugeny.Kuznetsov@nokia.com> <1286970199.12782.28.camel@ekuznets-lx-nokia> <1286971758.12782.35.camel@ekuznets-lx-nokia> <1287123378.12782.49.camel@ekuznets-lx-nokia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1287123378.12782.49.camel@ekuznets-lx-nokia> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Evgeny Kuznetsov [101014 23:11]: > On Wed, 2010-10-13 at 16:09 +0400, Evgeny Kuznetsov wrote: > > On Wed, 2010-10-13 at 17:20 +0530, ext Varadarajan, Charulatha wrote: > Hi Tony, > > It is not a bug fix, it is just check to prevent potential issues. Used > to warn in case of bug and prevent kernel oops. Check added only here > (not all gpio code cleanup) since here it could cause kernel opps. > > Would you apply patch if I will leave only if condition section in > patch? > > if (WARN_ON(!isr_reg)) > goto exit; > > If yes, I'll resend v3 patch. Sounds like a valid check to me. Tony