From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, jdike@addtoit.com,
user-mode-linux-devel@lists.sourceforge.net,
viro@zeniv.linux.org.uk, toralf.foerster@gmx.de,
Christoph Hellwig <hch@lst.de>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/1] hostfs: fix UML crash
Date: Tue, 19 Oct 2010 03:11:25 +0200 [thread overview]
Message-ID: <20101019011125.GA3905@lst.de> (raw)
In-Reply-To: <20101018130208.7b552527.akpm@linux-foundation.org>
On Mon, Oct 18, 2010 at 01:02:08PM -0700, Andrew Morton wrote:
> > >
> > > Is there any reason for hostfs to be playing with the f_spare field at all?
No, there is no reason at all. do_statfs is only called by
hostfs_statfs, which is the hostfs implementation of ->statfs. zeroing
of the spare fields is done by common code (vfs_statfs_native).
Can you submit a patch to just remove the spare_out argument to do_statfs?
> 365b1818 added f_flags to `struct statfs' but didn't carry that over to
> `struct compat_statfs' and hence didn't copy f_flags over into
> compat_statfs. Deliberate, or oversight?
Oversight.
next prev parent reply other threads:[~2010-10-19 1:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 16:36 [PATCH 1/1] hostfs: fix UML crash Richard Weinberger
2010-10-18 18:40 ` Andrew Morton
2010-10-18 18:53 ` Richard Weinberger
2010-10-18 20:02 ` Andrew Morton
2010-10-19 1:11 ` Christoph Hellwig [this message]
2010-10-19 10:27 ` Richard Weinberger
2010-10-18 19:22 ` [uml-devel] " Geert Uytterhoeven
2010-10-18 19:31 ` Richard Weinberger
2010-10-18 19:43 ` Geert Uytterhoeven
2010-10-18 20:03 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019011125.GA3905@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=toralf.foerster@gmx.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox