* [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled
@ 2010-10-07 7:51 Axel Lin
2010-10-07 16:32 ` Lars-Peter Clausen
2010-10-19 9:12 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2010-10-07 7:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Samuel Ortiz, Lars-Peter Clausen
When enabled is false, clear BIT(engine) of JZ_REG_ADC_ENABLE register.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/jz4740-adc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
index 3ad492c..9dd1b33 100644
--- a/drivers/mfd/jz4740-adc.c
+++ b/drivers/mfd/jz4740-adc.c
@@ -153,7 +153,7 @@ static inline void jz4740_adc_set_enabled(struct jz4740_adc *adc, int engine,
if (enabled)
val |= BIT(engine);
else
- val &= BIT(engine);
+ val &= ~BIT(engine);
writeb(val, adc->base + JZ_REG_ADC_ENABLE);
spin_unlock_irqrestore(&adc->lock, flags);
--
1.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled
2010-10-07 7:51 [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled Axel Lin
@ 2010-10-07 16:32 ` Lars-Peter Clausen
2010-10-19 9:12 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2010-10-07 16:32 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Samuel Ortiz
Axel Lin wrote:
> When enabled is false, clear BIT(engine) of JZ_REG_ADC_ENABLE register.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
- Lars
> ---
> drivers/mfd/jz4740-adc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index 3ad492c..9dd1b33 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -153,7 +153,7 @@ static inline void jz4740_adc_set_enabled(struct jz4740_adc *adc, int engine,
> if (enabled)
> val |= BIT(engine);
> else
> - val &= BIT(engine);
> + val &= ~BIT(engine);
> writeb(val, adc->base + JZ_REG_ADC_ENABLE);
>
> spin_unlock_irqrestore(&adc->lock, flags);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled
2010-10-07 7:51 [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled Axel Lin
2010-10-07 16:32 ` Lars-Peter Clausen
@ 2010-10-19 9:12 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2010-10-19 9:12 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Lars-Peter Clausen
Hi Axel,
On Thu, Oct 07, 2010 at 03:51:20PM +0800, Axel Lin wrote:
> When enabled is false, clear BIT(engine) of JZ_REG_ADC_ENABLE register.
Patch applied, thanks.
Cheers,
Samuel.
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/jz4740-adc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index 3ad492c..9dd1b33 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -153,7 +153,7 @@ static inline void jz4740_adc_set_enabled(struct jz4740_adc *adc, int engine,
> if (enabled)
> val |= BIT(engine);
> else
> - val &= BIT(engine);
> + val &= ~BIT(engine);
> writeb(val, adc->base + JZ_REG_ADC_ENABLE);
>
> spin_unlock_irqrestore(&adc->lock, flags);
> --
> 1.7.2
>
>
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-19 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-07 7:51 [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled Axel Lin
2010-10-07 16:32 ` Lars-Peter Clausen
2010-10-19 9:12 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox