From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] mfd: Add WM831x SPI support
Date: Tue, 19 Oct 2010 12:52:32 +0200 [thread overview]
Message-ID: <20101019105232.GN2736@sortiz-mobl> (raw)
In-Reply-To: <20101019095347.GC11371@opensource.wolfsonmicro.com>
Hi Mark,
On Tue, Oct 19, 2010 at 02:53:54AM -0700, Mark Brown wrote:
> On Tue, Oct 19, 2010 at 11:44:23AM +0200, Samuel Ortiz wrote:
>
> > > +static int wm831x_spi_write_device(struct wm831x *wm831x, unsigned short reg,
> > > + int bytes, void *src)
> > > +{
> > > + struct spi_device *spi = wm831x->control_data;
> > > + u16 *s = src;
> > > + u16 data[2];
> > > + int ret;
> > > +
> > > + /* Go register at a time */
> > > + for (r = reg; r < reg + (bytes / 2); r++) {
> > > + data[0] = r;
>
> Oh, gah. We need an extra int r here, I've obviously stuffed up the
> move from the BSP I was working on. Sorry about that:
No problem, I didn't see it as I haven't build my tree yet.
I squashed this fix into the initial patch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-10-19 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 21:23 [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver Mark Brown
2010-10-08 21:23 ` [PATCH 2/2] mfd: Add WM831x SPI support Mark Brown
2010-10-19 9:44 ` Samuel Ortiz
2010-10-19 9:53 ` Mark Brown
2010-10-19 10:52 ` Samuel Ortiz [this message]
2010-10-19 9:43 ` [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver Samuel Ortiz
2010-10-19 11:15 ` Samuel Ortiz
2010-10-19 15:14 ` Mark Brown
2010-10-19 15:27 ` Samuel Ortiz
2010-10-19 17:51 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-10-08 16:52 Mark Brown
2010-10-08 16:52 ` [PATCH 2/2] mfd: Add WM831x SPI support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019105232.GN2736@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox