From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver
Date: Tue, 19 Oct 2010 13:15:54 +0200 [thread overview]
Message-ID: <20101019111553.GO2736@sortiz-mobl> (raw)
In-Reply-To: <1286573003-13889-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Fri, Oct 08, 2010 at 02:23:22PM -0700, Mark Brown wrote:
> diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
> index 1e4d78a..546db5c 100644
> --- a/arch/arm/mach-s3c64xx/Kconfig
> +++ b/arch/arm/mach-s3c64xx/Kconfig
> @@ -185,6 +185,7 @@ config SMDK6410_WM1192_EV1
> select REGULATOR_WM831X
> select S3C24XX_GPIO_EXTRA64
> select MFD_WM831X
> + select MFD_WM831X_I2C
> help
> The Wolfson Microelectronics 1192-EV1 is a WM831x based PMIC
> daughtercard for the Samsung SMDK6410 reference platform.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6c6b9f0..608a277 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -315,14 +315,18 @@ config MFD_WM8400
> the functionality of the device.
>
> config MFD_WM831X
> - bool "Support Wolfson Microelectronics WM831x/2x PMICs"
> + bool
> + depends on GENERIC_HARDIRQS
> +
> +config MFD_WM831X_I2C
> + bool "Support Wolfson Microelectronics WM831x/2x PMICs with I2C"
> select MFD_CORE
I think we should select MFD_WM831X here as well otherwise there's nothing
preventing us from building the I2C or the SPI part without the core one. And
that leads to a build breakage.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-10-19 11:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 21:23 [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver Mark Brown
2010-10-08 21:23 ` [PATCH 2/2] mfd: Add WM831x SPI support Mark Brown
2010-10-19 9:44 ` Samuel Ortiz
2010-10-19 9:53 ` Mark Brown
2010-10-19 10:52 ` Samuel Ortiz
2010-10-19 9:43 ` [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver Samuel Ortiz
2010-10-19 11:15 ` Samuel Ortiz [this message]
2010-10-19 15:14 ` Mark Brown
2010-10-19 15:27 ` Samuel Ortiz
2010-10-19 17:51 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-10-08 16:52 Mark Brown
2010-10-08 18:57 ` Stefan Schmidt
2010-10-08 18:58 ` Mark Brown
2010-10-19 9:38 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019111553.GO2736@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox