* [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
@ 2010-03-02 16:22 Uwe Kleine-König
2010-10-19 7:19 ` Uwe Kleine-König
0 siblings, 1 reply; 8+ messages in thread
From: Uwe Kleine-König @ 2010-03-02 16:22 UTC (permalink / raw)
To: linux-kernel; +Cc: Ian Molton, Magnus Damm, Samuel Ortiz
tc6393xb_mmc_resources (which was marked __devinitdata) is used in
tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
living in .text. This is not save with CONFIG_HOTPLUG=n.
This was introduced in
64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Ian Molton <ian@mnementh.co.uk>
Cc: Magnus Damm <damm@opensource.se>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
drivers/mfd/tc6393xb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
index 4bc5a08..b057d8d 100644
--- a/drivers/mfd/tc6393xb.c
+++ b/drivers/mfd/tc6393xb.c
@@ -154,7 +154,7 @@ static struct resource __devinitdata tc6393xb_nand_resources[] = {
},
};
-static struct resource __devinitdata tc6393xb_mmc_resources[] = {
+static struct resource tc6393xb_mmc_resources[] = {
{
.start = 0x800,
.end = 0x9ff,
--
1.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
2010-03-02 16:22 [PATCH] mfd/tc6393xb: don't use devinit data from non-init function Uwe Kleine-König
@ 2010-10-19 7:19 ` Uwe Kleine-König
2010-10-19 7:44 ` Ian Molton
2010-10-19 10:31 ` Samuel Ortiz
0 siblings, 2 replies; 8+ messages in thread
From: Uwe Kleine-König @ 2010-10-19 7:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Ian Molton, Magnus Damm, Samuel Ortiz
Hello,
On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> living in .text. This is not save with CONFIG_HOTPLUG=n.
>
> This was introduced in
>
> 64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Ian Molton <ian@mnementh.co.uk>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
ping
Uwe
> ---
> drivers/mfd/tc6393xb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index 4bc5a08..b057d8d 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -154,7 +154,7 @@ static struct resource __devinitdata tc6393xb_nand_resources[] = {
> },
> };
>
> -static struct resource __devinitdata tc6393xb_mmc_resources[] = {
> +static struct resource tc6393xb_mmc_resources[] = {
> {
> .start = 0x800,
> .end = 0x9ff,
> --
> 1.7.0
>
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
2010-10-19 7:19 ` Uwe Kleine-König
@ 2010-10-19 7:44 ` Ian Molton
2010-10-19 10:31 ` Samuel Ortiz
1 sibling, 0 replies; 8+ messages in thread
From: Ian Molton @ 2010-10-19 7:44 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, Magnus Damm, Samuel Ortiz
I already acked it... wonder where it went?
Acked-by: Ian Molton <ian@mnementh.co.uk>
:)
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
2010/10/19 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
>> tc6393xb_mmc_resources (which was marked __devinitdata) is used in
>> tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
>> living in .text. This is not save with CONFIG_HOTPLUG=n.
>>
>> This was introduced in
>>
>> 64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Cc: Ian Molton <ian@mnementh.co.uk>
>> Cc: Magnus Damm <damm@opensource.se>
>> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ping
>
> Uwe
>> ---
>> drivers/mfd/tc6393xb.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
>> index 4bc5a08..b057d8d 100644
>> --- a/drivers/mfd/tc6393xb.c
>> +++ b/drivers/mfd/tc6393xb.c
>> @@ -154,7 +154,7 @@ static struct resource __devinitdata tc6393xb_nand_resources[] = {
>> },
>> };
>>
>> -static struct resource __devinitdata tc6393xb_mmc_resources[] = {
>> +static struct resource tc6393xb_mmc_resources[] = {
>> {
>> .start = 0x800,
>> .end = 0x9ff,
>> --
>> 1.7.0
>>
>>
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
2010-10-19 7:19 ` Uwe Kleine-König
2010-10-19 7:44 ` Ian Molton
@ 2010-10-19 10:31 ` Samuel Ortiz
2010-10-19 13:07 ` Uwe Kleine-König
1 sibling, 1 reply; 8+ messages in thread
From: Samuel Ortiz @ 2010-10-19 10:31 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, Ian Molton, Magnus Damm
Hi Uwe,
On Tue, Oct 19, 2010 at 09:19:51AM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> > tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> > tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> > living in .text. This is not save with CONFIG_HOTPLUG=n.
> >
> > This was introduced in
> >
> > 64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Ian Molton <ian@mnementh.co.uk>
> > Cc: Magnus Damm <damm@opensource.se>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> ping
This one slipped through...
I just applied a similar patch from Marek Vasut, are you ok with that ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
2010-10-19 10:31 ` Samuel Ortiz
@ 2010-10-19 13:07 ` Uwe Kleine-König
2010-10-19 13:22 ` Samuel Ortiz
0 siblings, 1 reply; 8+ messages in thread
From: Uwe Kleine-König @ 2010-10-19 13:07 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, Ian Molton, Magnus Damm
On Tue, Oct 19, 2010 at 12:31:31PM +0200, Samuel Ortiz wrote:
> Hi Uwe,
>
> On Tue, Oct 19, 2010 at 09:19:51AM +0200, Uwe Kleine-König wrote:
> > Hello,
> >
> > On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> > > tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> > > tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> > > living in .text. This is not save with CONFIG_HOTPLUG=n.
> > >
> > > This was introduced in
> > >
> > > 64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > Cc: Ian Molton <ian@mnementh.co.uk>
> > > Cc: Magnus Damm <damm@opensource.se>
> > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > ping
> This one slipped through...
> I just applied a similar patch from Marek Vasut, are you ok with that ?
Hmm, cannot find it, neither in next nor in your tree.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
2010-10-19 13:07 ` Uwe Kleine-König
@ 2010-10-19 13:22 ` Samuel Ortiz
2010-10-19 13:33 ` Uwe Kleine-König
0 siblings, 1 reply; 8+ messages in thread
From: Samuel Ortiz @ 2010-10-19 13:22 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, Ian Molton, Magnus Damm
On Tue, Oct 19, 2010 at 03:07:05PM +0200, Uwe Kleine-König wrote:
> On Tue, Oct 19, 2010 at 12:31:31PM +0200, Samuel Ortiz wrote:
> > Hi Uwe,
> >
> > On Tue, Oct 19, 2010 at 09:19:51AM +0200, Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> > > > tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> > > > tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> > > > living in .text. This is not save with CONFIG_HOTPLUG=n.
> > > >
> > > > This was introduced in
> > > >
> > > > 64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
> > > >
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > Cc: Ian Molton <ian@mnementh.co.uk>
> > > > Cc: Magnus Damm <damm@opensource.se>
> > > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > > ping
> > This one slipped through...
> > I just applied a similar patch from Marek Vasut, are you ok with that ?
> Hmm, cannot find it, neither in next nor in your tree.
I just pushed it now.
See http://www.spinics.net/lists/arm-kernel/msg101220.html if you still can't
get it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
2010-10-19 13:22 ` Samuel Ortiz
@ 2010-10-19 13:33 ` Uwe Kleine-König
2010-10-19 13:34 ` Samuel Ortiz
0 siblings, 1 reply; 8+ messages in thread
From: Uwe Kleine-König @ 2010-10-19 13:33 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, Ian Molton, Magnus Damm
On Tue, Oct 19, 2010 at 03:22:29PM +0200, Samuel Ortiz wrote:
> On Tue, Oct 19, 2010 at 03:07:05PM +0200, Uwe Kleine-König wrote:
> > On Tue, Oct 19, 2010 at 12:31:31PM +0200, Samuel Ortiz wrote:
> > > Hi Uwe,
> > >
> > > On Tue, Oct 19, 2010 at 09:19:51AM +0200, Uwe Kleine-König wrote:
> > > > Hello,
> > > >
> > > > On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> > > > > tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> > > > > tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> > > > > living in .text. This is not save with CONFIG_HOTPLUG=n.
> > > > >
> > > > > This was introduced in
> > > > >
> > > > > 64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
> > > > >
> > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > > Cc: Ian Molton <ian@mnementh.co.uk>
> > > > > Cc: Magnus Damm <damm@opensource.se>
> > > > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > > > ping
> > > This one slipped through...
> > > I just applied a similar patch from Marek Vasut, are you ok with that ?
> > Hmm, cannot find it, neither in next nor in your tree.
> I just pushed it now.
> See http://www.spinics.net/lists/arm-kernel/msg101220.html if you still can't
> get it.
the change is identical, so OK. I would have written "This patch fixes
a section mismatch.", not "Also, this causes a section mismatch."
But I don't care much.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function
2010-10-19 13:33 ` Uwe Kleine-König
@ 2010-10-19 13:34 ` Samuel Ortiz
0 siblings, 0 replies; 8+ messages in thread
From: Samuel Ortiz @ 2010-10-19 13:34 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, Ian Molton, Magnus Damm
On Tue, Oct 19, 2010 at 03:33:44PM +0200, Uwe Kleine-König wrote:
> On Tue, Oct 19, 2010 at 03:22:29PM +0200, Samuel Ortiz wrote:
> > On Tue, Oct 19, 2010 at 03:07:05PM +0200, Uwe Kleine-König wrote:
> > > On Tue, Oct 19, 2010 at 12:31:31PM +0200, Samuel Ortiz wrote:
> > > > Hi Uwe,
> > > >
> > > > On Tue, Oct 19, 2010 at 09:19:51AM +0200, Uwe Kleine-König wrote:
> > > > > Hello,
> > > > >
> > > > > On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> > > > > > tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> > > > > > tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> > > > > > living in .text. This is not save with CONFIG_HOTPLUG=n.
> > > > > >
> > > > > > This was introduced in
> > > > > >
> > > > > > 64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
> > > > > >
> > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > > > Cc: Ian Molton <ian@mnementh.co.uk>
> > > > > > Cc: Magnus Damm <damm@opensource.se>
> > > > > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > > > > ping
> > > > This one slipped through...
> > > > I just applied a similar patch from Marek Vasut, are you ok with that ?
> > > Hmm, cannot find it, neither in next nor in your tree.
> > I just pushed it now.
> > See http://www.spinics.net/lists/arm-kernel/msg101220.html if you still can't
> > get it.
> the change is identical, so OK.
Thanks for checking.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-10-19 13:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-02 16:22 [PATCH] mfd/tc6393xb: don't use devinit data from non-init function Uwe Kleine-König
2010-10-19 7:19 ` Uwe Kleine-König
2010-10-19 7:44 ` Ian Molton
2010-10-19 10:31 ` Samuel Ortiz
2010-10-19 13:07 ` Uwe Kleine-König
2010-10-19 13:22 ` Samuel Ortiz
2010-10-19 13:33 ` Uwe Kleine-König
2010-10-19 13:34 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox