From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Stefani Seibold <stefani@seibold.net>
Subject: kfifo must_check warning
Date: Tue, 19 Oct 2010 15:10:48 -0700 [thread overview]
Message-ID: <20101019151048.ae79bb25.randy.dunlap@oracle.com> (raw)
In 2.6.36-rc8, I see this build warning:
drivers/char/n_gsm.c: In function 'gsm_dlci_alloc':
drivers/char/n_gsm.c:1580: warning: ignoring return value of '__kfifo_must_check_helper', declared with attribute warn_unused_result
The helper seems to be getting in the way (?). The driver code does this:
if (kfifo_alloc(&dlci->_fifo, 4096, GFP_KERNEL) < 0) {
kfree(dlci);
return NULL;
}
Should the driver code be doing something else?
or should the kfifo_alloc() macro be checking the result of the helper?
thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next reply other threads:[~2010-10-19 22:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 22:10 Randy Dunlap [this message]
2010-10-20 5:12 ` kfifo must_check warning Andrew Morton
2010-10-20 16:46 ` kfifo must_check warning (+ patch) Randy Dunlap
2010-10-20 17:51 ` miltonm
2010-10-20 18:37 ` Alan Cox
2010-10-20 18:56 ` Andrew Morton
2010-10-20 20:09 ` Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019151048.ae79bb25.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox