* [PATCH] kernel: printk: Fix a coding style issue.
@ 2010-10-19 18:19 Ralf Thielow
2010-10-19 22:20 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Thielow @ 2010-10-19 18:19 UTC (permalink / raw)
To: akpm; +Cc: jason.wessel, linux-kernel, Ralf Thielow
Fixed a coding style issue of "do_syslog" in
case of open or close the log.
Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
kernel/printk.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/printk.c b/kernel/printk.c
index 8fe465a..3539744 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -273,9 +273,8 @@ int do_syslog(int type, char __user *buf, int len, bool from_file)
return error;
switch (type) {
- case SYSLOG_ACTION_CLOSE: /* Close log */
- break;
case SYSLOG_ACTION_OPEN: /* Open log */
+ case SYSLOG_ACTION_CLOSE: /* Close log */
break;
case SYSLOG_ACTION_READ: /* Read from log */
error = -EINVAL;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel: printk: Fix a coding style issue.
2010-10-19 18:19 [PATCH] kernel: printk: Fix a coding style issue Ralf Thielow
@ 2010-10-19 22:20 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2010-10-19 22:20 UTC (permalink / raw)
To: Ralf Thielow; +Cc: jason.wessel, linux-kernel
On Tue, 19 Oct 2010 20:19:01 +0200
Ralf Thielow <ralf.thielow@googlemail.com> wrote:
> Fixed a coding style issue of "do_syslog" in
> case of open or close the log.
>
> Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
> ---
> kernel/printk.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/printk.c b/kernel/printk.c
> index 8fe465a..3539744 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -273,9 +273,8 @@ int do_syslog(int type, char __user *buf, int len, bool from_file)
> return error;
>
> switch (type) {
> - case SYSLOG_ACTION_CLOSE: /* Close log */
> - break;
> case SYSLOG_ACTION_OPEN: /* Open log */
> + case SYSLOG_ACTION_CLOSE: /* Close log */
> break;
> case SYSLOG_ACTION_READ: /* Read from log */
> error = -EINVAL;
I don't really think that the code needed fixing there?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-19 22:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-19 18:19 [PATCH] kernel: printk: Fix a coding style issue Ralf Thielow
2010-10-19 22:20 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox