From: Greg KH <greg@kroah.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-usb@vger.kernel.org,
linux-omap <linux-omap@vger.kernel.org>,
linux-main <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff
Date: Tue, 19 Oct 2010 08:52:19 -0700 [thread overview]
Message-ID: <20101019155219.GI4589@kroah.com> (raw)
In-Reply-To: <1287482608-11320-4-git-send-email-felipe.contreras@gmail.com>
On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote:
> Add missing dependencies, and remove redundant ones, and select sensible
> defaults.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> drivers/mfd/Kconfig | 3 ++-
> drivers/regulator/Kconfig | 1 +
> drivers/usb/gadget/Kconfig | 3 +--
> drivers/usb/musb/Kconfig | 6 ++----
> drivers/usb/otg/Kconfig | 2 ++
> 5 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index db51ea1..0bbaf01 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -156,6 +156,7 @@ config MENELAUS
> config TWL4030_CORE
> bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
> depends on I2C=y && GENERIC_HARDIRQS
> + default y if ARCH_OMAP3 || ARCH_OMAP4
Sorry, but unless the driver is somehow required to keep the board from
going up in a puff of smoke, a default should NEVER be y.
Because of that, I can't take this patch.
greg k-h
next prev parent reply other threads:[~2010-10-19 15:55 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 10:03 [PATCH v2 0/3] usb: generic Kconfig fixes Felipe Contreras
2010-10-19 10:03 ` [PATCH v2 1/3] usb: fix Kconfig warning Felipe Contreras
2010-10-19 10:28 ` Felipe Balbi
2010-10-19 15:50 ` Greg KH
2010-10-20 6:34 ` Felipe Balbi
2010-10-19 10:03 ` [PATCH v2 2/3] usb: trivial Kconfig cleanups Felipe Contreras
2010-10-19 15:51 ` Greg KH
2010-10-19 17:15 ` Felipe Contreras
2010-10-19 17:50 ` Greg KH
2010-10-19 18:15 ` Felipe Contreras
2010-10-20 18:25 ` Felipe Balbi
2010-10-19 10:03 ` [PATCH v2 3/3] drivers: cleanup Kconfig stuff Felipe Contreras
2010-10-19 10:32 ` Felipe Balbi
2010-10-19 10:59 ` Felipe Contreras
2010-10-19 11:16 ` Felipe Balbi
2010-10-19 11:36 ` Felipe Contreras
2010-10-19 11:52 ` Felipe Balbi
2010-10-19 14:32 ` Felipe Contreras
2010-10-19 15:05 ` Felipe Balbi
2010-10-19 20:52 ` Felipe Contreras
2010-10-19 23:44 ` Tony Lindgren
2010-10-20 0:13 ` Kevin Hilman
2010-10-20 0:31 ` Tony Lindgren
2010-10-20 6:35 ` Felipe Balbi
2010-10-20 8:47 ` felipe.contreras
2010-10-19 13:40 ` Roger Quadros
2010-10-19 14:33 ` Felipe Contreras
2010-10-20 7:46 ` Roger Quadros
2010-10-20 8:01 ` Felipe Balbi
2010-10-20 8:53 ` felipe.contreras
2010-10-20 9:14 ` Roger Quadros
2010-10-20 9:23 ` Felipe Contreras
2010-10-20 12:33 ` Roger Quadros
2010-10-20 14:38 ` Felipe Contreras
2010-10-21 14:07 ` Roger Quadros
2010-10-21 15:41 ` Felipe Balbi
2010-10-21 15:57 ` Tony Lindgren
2010-10-20 12:33 ` Roger Quadros
2010-10-20 12:54 ` Felipe Balbi
2010-10-20 14:52 ` Felipe Contreras
2010-10-20 15:15 ` Felipe Balbi
2010-10-20 16:22 ` Felipe Contreras
2010-10-20 17:54 ` Felipe Balbi
2010-10-21 9:04 ` Felipe Contreras
2010-10-21 10:24 ` Felipe Balbi
2010-10-21 10:55 ` Felipe Contreras
2010-10-19 15:52 ` Greg KH [this message]
2010-10-19 16:12 ` Anand Gadiyar
2010-10-19 16:23 ` Greg KH
2010-10-19 17:06 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019155219.GI4589@kroah.com \
--to=greg@kroah.com \
--cc=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox