public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/3] staging: batman-adv: remove useless addr_to_string()
Date: Tue, 19 Oct 2010 10:03:42 -0700	[thread overview]
Message-ID: <20101019170342.GA18575@kroah.com> (raw)
In-Reply-To: <11c47095d961ba40ad95ecf995094e78e4d96fdf.1287223789.git.andy.shevchenko@gmail.com>

On Sat, Oct 16, 2010 at 01:11:10PM +0300, Andy Shevchenko wrote:
> Since all *printf() methods in the kernel understand '%pM' modifier the
> conversion to the string is useless beforehand.
> 
> Additionally this patch decreases batman_if structure by 20 bytes.

And also, it breaks the build:
	drivers/staging/batman-adv/vis.c: In function ‘vis_data_read_entry’:
	drivers/staging/batman-adv/vis.c:170:38: error: ‘to’ undeclared (first use in this function)
	drivers/staging/batman-adv/vis.c:170:38: note: each undeclared identifier is reported only once for each function it appears in

Please always test your patches :(

I've dropped this one.

thanks,

greg k-h

  parent reply	other threads:[~2010-10-19 17:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-16 10:11 [PATCH 1/3] staging: batman-adv: remove useless addr_to_string() Andy Shevchenko
2010-10-16 10:11 ` [PATCH 2/3] staging: wlags49_h2: fix format of timeStamp debug output Andy Shevchenko
2010-10-16 10:11 ` [PATCH 3/3] staging: wlags49_h2: remove useless DbgHwAddr() method Andy Shevchenko
2010-10-19 17:03 ` Greg KH [this message]
2010-10-20 11:27   ` [PATCH 1/3] staging: batman-adv: remove useless addr_to_string() Andy Shevchenko
2010-10-20 11:27   ` [PATCHv2] " Andy Shevchenko
2010-10-20 14:14     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101019170342.GA18575@kroah.com \
    --to=greg@kroah.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox