From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com
Cc: xen-devel@lists.xensource.com,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
linux-kernel@vger.kernel.org, Qing He <qing.he@intel.com>,
Yunhong Jiang <yunhong.jiang@intel.com>
Subject: Re: [Xen-devel] [PATCH v4 03/10] xen: remap MSIs into pirqs when running as initial domain
Date: Tue, 19 Oct 2010 16:24:47 -0400 [thread overview]
Message-ID: <20101019202447.GA10052@dumpdata.com> (raw)
In-Reply-To: <20101019201518.GA9727@dumpdata.com>
> > + rc = HYPERVISOR_physdev_op(PHYSDEVOP_map_pirq, &map_irq);
> > + if (rc) {
> > + printk(KERN_WARNING "xen map irq failed %d\n", rc);
> > +
> > + dynamic_irq_cleanup(irq);
>
> Looking at include/linux/irq.h, I see this commment:
> /*
> 330 * Dynamic irq helper functions. Obsolete. Use irq_alloc_desc* and
> 331 * irq_free_desc instead.
> 332 */
>
> So we should use irq_free_desc instead of dynamic_irq_cleanup.
> (fyi, I didn't realize this until I started pulling in the sparse_irq
> patchset).
I looked at the rest of the patches and they all look good to me. Fix
this above and you can stick
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
on all the patches.
next prev parent reply other threads:[~2010-10-19 20:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 11:16 [PATCH v4 00/10] xen: initial domain support Stefano Stabellini
2010-10-19 11:17 ` [PATCH v4 01/10] xen: introduce XEN_DOM0 as a silent option stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 02/10] xen: remap GSIs as pirqs when running as initial domain stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 03/10] xen: remap MSIs into " stefano.stabellini
2010-10-19 20:15 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-10-19 20:24 ` Konrad Rzeszutek Wilk [this message]
2010-10-19 11:17 ` [PATCH v4 04/10] xen: map a dummy page for local apic and ioapic in xen_set_fixmap stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 05/10] xen: use vcpu_ops to setup cpu masks stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 06/10] xen: Initialize xenbus for dom0 stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 07/10] xen: add the direct mapping area for ISA bus access stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 08/10] xen: use host E820 map for dom0 stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 09/10] xen: make hvc_xen console work " stefano.stabellini
2010-10-19 11:17 ` [PATCH v4 10/10] xen: mask the MTRR feature from the cpuid stefano.stabellini
2010-10-19 21:14 ` [PATCH v4 00/10] xen: initial domain support Greg KH
2010-10-19 21:54 ` [Xen-devel] " Jeremy Fitzhardinge
2010-10-19 23:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019202447.GA10052@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qing.he@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox