From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: pavan_savoy@ti.com
Cc: marcel@holtmann.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Bluetooth: btwilink driver
Date: Tue, 19 Oct 2010 18:39:13 -0200 [thread overview]
Message-ID: <20101019203913.GA2322@vigoh> (raw)
In-Reply-To: <1287521858-15190-1-git-send-email-pavan_savoy@ti.com>
* pavan_savoy@ti.com <pavan_savoy@ti.com> [2010-10-19 16:57:38 -0400]:
> From: Pavan Savoy <pavan_savoy@ti.com>
>
> v3 comments
>
> Marcel, Gustavo, & list,
> Please review this version of patch.
>
> Anderson,
> I have taken care of most of the comments you had.
> Have re-wrote some of the code commenting you've mentioned.
> Thanks for the comments,
>
> The other few like -EPERM for platform driver registration is to keep
> it similar to other drivers
Which drivers returns -EPERM to any kind of error? The are many reasons
why the funcion can fail, and you want to give the best error report to the
user. Use EPERM to all of them is just wrong.
>type casting is maintained just to feel safe
> and have style similar to other drivers.
We don't need to feel safe here. Type cast actually can hide errors,
only use them when you really need to cast, in many case here you don't.
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next prev parent reply other threads:[~2010-10-19 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 20:57 [PATCH v3] Bluetooth: btwilink driver pavan_savoy
2010-10-19 20:39 ` Gustavo F. Padovan [this message]
2010-10-19 20:45 ` Savoy, Pavan
2010-10-19 20:54 ` Gustavo F. Padovan
2010-10-19 20:54 ` Savoy, Pavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019203913.GA2322@vigoh \
--to=padovan@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pavan_savoy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox