From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757281Ab0JTDao (ORCPT ); Tue, 19 Oct 2010 23:30:44 -0400 Received: from imr3.ericy.com ([198.24.6.13]:33058 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756647Ab0JTDan (ORCPT ); Tue, 19 Oct 2010 23:30:43 -0400 Date: Tue, 19 Oct 2010 20:29:38 -0700 From: Guenter Roeck To: Joe Perches CC: Jean Delvare , Hans de Goede , Alistair John Strachan , Henrik Rydberg , "Mark M. Hoffman" , Luca Tettamanti , Fenghua Yu , Juerg Haefliger , Eric Piel , Jim Cromie , Roger Lucas , "lm-sensors@lm-sensors.org" , LKML Subject: Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_ Message-ID: <20101020032938.GA20095@ericsson.com> References: <1287530020.10409.594.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1287530020.10409.594.camel@Joe-Laptop> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 19, 2010 at 07:13:40PM -0400, Joe Perches wrote: > Convert printks to pr_ > Coalesce long formats > Removed prefixes from formats > Added #define pr_fmt KBUILD_MODNAME ": " fmt > Standardized abitguru messages for reporting and finding MAINTAINER > > Compiled x86 allyesconfig only. > I inspected "strings drivers/hwmon/built-in.o", > but it's otherwise untested. > > Signed-off-by: Joe Perches There are several lines longer than 80 characters. Does this rule no longer apply ? Oddly enough, there are only four checkpatch warnings about long lines, even though there are many more. Guenter