From: Andi Kleen <andi@firstfloor.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
"hpa@zytor.com" <hpa@zytor.com>, Andi Kleen <andi@firstfloor.org>,
"Chen, Tim C" <tim.c.chen@intel.com>
Subject: Re: [PATCH 2/2]x86: spread tlb flush vector between nodes
Date: Wed, 20 Oct 2010 09:30:27 +0200 [thread overview]
Message-ID: <20101020073027.GA20124@basil.fritz.box> (raw)
In-Reply-To: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Hi Shaohua,
> + if (nr_online_nodes > NUM_INVALIDATE_TLB_VECTORS)
> + nr_node_vecs = 1;
> + else
> + nr_node_vecs = NUM_INVALIDATE_TLB_VECTORS/nr_online_nodes;
Does this build without CONFIG_NUMA? AFAIK nr_online_nodes is only
defined for a numa kernel.
> +
> +static int tlb_cpuhp_notify(struct notifier_block *n,
> + unsigned long action, void *hcpu)
> +{
> + switch (action & 0xf) {
> + case CPU_ONLINE:
> + case CPU_DEAD:
> + calculate_tlb_offset();
I still think the notifier is overkill and a static mapping at boot time
would be fine.
The rest looks ok to me.
-andi
next prev parent reply other threads:[~2010-10-20 7:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 3:07 [PATCH 2/2]x86: spread tlb flush vector between nodes Shaohua Li
2010-10-20 5:16 ` Eric Dumazet
2010-10-20 7:31 ` Andi Kleen
2010-10-20 11:20 ` Peter Zijlstra
2010-10-20 12:06 ` Andi Kleen
2010-10-20 12:08 ` Peter Zijlstra
2010-10-20 12:18 ` Andi Kleen
2010-10-20 7:30 ` Andi Kleen [this message]
2010-10-20 8:44 ` Shaohua Li
2010-10-20 23:07 ` [tip:x86/mm] x86: Spread " tip-bot for Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020073027.GA20124@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shaohua.li@intel.com \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox