Re: [PATCH 2/2]x86: spread tlb flush vector between nodes

Andi Kleen
2010-10-20T07:30:34Z

Hi Shaohua,

> + if (nr_online_nodes > NUM_INVALIDATE_TLB_VECTORS)
> + nr_node_vecs = 1;
> + else
> + nr_node_vecs = NUM_INVALIDATE_TLB_VECTORS/nr_online_nodes;

Does this build without CONFIG_NUMA? AFAIK nr_online_nodes is only
defined for a numa kernel.

> +
> +static int tlb_cpuhp_notify(struct notifier_block *n,
> + unsigned long action, void *hcpu)
> +{
> + switch (action & 0xf) {
> + case CPU_ONLINE:
> + case CPU_DEAD:
> + calculate_tlb_offset();

I still think the notifier is overkill and a static mapping at boot time
would be fine.

The rest looks ok to me.

-andi