From: Andres Salomon <dilinger@queued.net>
To: Daniel Drake <dsd@laptop.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
randy.dunlap@oracle.com
Subject: Re: [PATCH v2] OLPC: Add XO-1 suspend/resume support
Date: Wed, 20 Oct 2010 09:06:13 -0700 [thread overview]
Message-ID: <20101020090613.2e969a6f@queued.net> (raw)
In-Reply-To: <20101020151723.9F6F89D401B@zog.reactivated.net>
On Wed, 20 Oct 2010 16:17:23 +0100 (BST)
Daniel Drake <dsd@laptop.org> wrote:
> Add code needed for basic suspend/resume of the XO-1 laptop.
>
> Signed-off-by: Daniel Drake <dsd@laptop.org>
> ---
> arch/x86/Kconfig | 2 +-
> arch/x86/include/asm/olpc.h | 5 +-
> arch/x86/kernel/Makefile | 2 +-
> arch/x86/kernel/olpc-xo1-wakeup.S | 133
> +++++++++++++++++++++++++++++++++++++
> arch/x86/kernel/olpc-xo1.c | 79 ++++++++++++++++++++++ 5
> files changed, 218 insertions(+), 3 deletions(-) create mode 100644
> arch/x86/kernel/olpc-xo1-wakeup.S
>
> v2: add dependency on CONFIG_PM_SLEEP (thanks Randy), avoid
> requirement on hacking swsusp_pg_dir by switching to
> initial_page_table Depends on the following patch:
> x86-32, mm: Add an initial page table for core bootstrapping
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 6a81891..581abc7 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2036,7 +2036,7 @@ config OLPC
>
> config OLPC_XO1
> tristate "OLPC XO-1 support"
> - depends on OLPC && PCI
> + depends on OLPC && PCI && PM_SLEEP
> ---help---
My suggestion would be:
config OLPC_XO1_PM
bool
depends on OLPC && PCI && PM_SLEEP
default y
No help necessary; just silently turn it on if PM_SLEEP is enabled, but
don't make all OLPC support dependent upon PM_SLEEP.
next prev parent reply other threads:[~2010-10-20 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 15:17 [PATCH v2] OLPC: Add XO-1 suspend/resume support Daniel Drake
2010-10-20 16:06 ` Andres Salomon [this message]
2010-10-20 17:02 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020090613.2e969a6f@queued.net \
--to=dilinger@queued.net \
--cc=bp@alien8.de \
--cc=dsd@laptop.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox