From: Greg KH <gregkh@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] staging: batman-adv: remove useless addr_to_string()
Date: Wed, 20 Oct 2010 07:14:26 -0700 [thread overview]
Message-ID: <20101020141426.GA14590@suse.de> (raw)
In-Reply-To: <1287574044-23000-1-git-send-email-andy.shevchenko@gmail.com>
On Wed, Oct 20, 2010 at 02:27:24PM +0300, Andy Shevchenko wrote:
> Since all *printf() methods in the kernel understand '%pM' modifier the
> conversion to the string is useless beforehand.
>
> Additionally this patch decreases batman_if structure by 20 bytes.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Please also read the TODO file in this directory, which says who to copy
on patches for these files. Care to resend it with those addresses
added?
thanks,
greg k-h
prev parent reply other threads:[~2010-10-20 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 10:11 [PATCH 1/3] staging: batman-adv: remove useless addr_to_string() Andy Shevchenko
2010-10-16 10:11 ` [PATCH 2/3] staging: wlags49_h2: fix format of timeStamp debug output Andy Shevchenko
2010-10-16 10:11 ` [PATCH 3/3] staging: wlags49_h2: remove useless DbgHwAddr() method Andy Shevchenko
2010-10-19 17:03 ` [PATCH 1/3] staging: batman-adv: remove useless addr_to_string() Greg KH
2010-10-20 11:27 ` Andy Shevchenko
2010-10-20 11:27 ` [PATCHv2] " Andy Shevchenko
2010-10-20 14:14 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020141426.GA14590@suse.de \
--to=gregkh@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox