From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753418Ab0JTOrV (ORCPT ); Wed, 20 Oct 2010 10:47:21 -0400 Received: from imr3.ericy.com ([198.24.6.13]:33048 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753122Ab0JTOrR (ORCPT ); Wed, 20 Oct 2010 10:47:17 -0400 Date: Wed, 20 Oct 2010 07:46:08 -0700 From: Guenter Roeck To: Jean Delvare CC: Joe Perches , Hans de Goede , Alistair John Strachan , Henrik Rydberg , "Mark M. Hoffman" , Luca Tettamanti , Fenghua Yu , Juerg Haefliger , Eric Piel , Jim Cromie , Roger Lucas , "lm-sensors@lm-sensors.org" , LKML Subject: Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_ Message-ID: <20101020144608.GA21937@ericsson.com> References: <1287530020.10409.594.camel@Joe-Laptop> <20101020032938.GA20095@ericsson.com> <1287545658.10409.606.camel@Joe-Laptop> <20101020035346.GA20178@ericsson.com> <1287547662.10409.618.camel@Joe-Laptop> <20101020093438.07b129c8@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20101020093438.07b129c8@endymion.delvare> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2010 at 03:34:38AM -0400, Jean Delvare wrote: [ ... ] > > * This isn't the kind of fixes we want to cherry-pick from. We're not > fixing any bug here, are we? I certainly hope that a real bug fix > wouldn't be hidden within a larger patch, but would have the separate > patch it deserves. At which point we no longer care if the rest is > one large patch or one patch per driver. > Actually, I do this kind of thing all the time when backporting. It is easier to apply all patches applied to a driver than skipping the cleanup patches, to avoid conflicts when cherry-picking functional patches. The tendency for large cleanup patches affecting several drivers and modules created trouble for me several times already. > * I don't see us reverting that kind of patch either. If we don't like > the changes for whatever reason, we don't take them in the first > place. Once in, we're not going to change our minds. > > * 32 patches for a simple cleanup is actually a lot more work for me > than a single large patch. It's cheaper for me to do minor > adjustments to a large patch than to apply 32 patches individually. > Good point. I am using git all the time, so it isn't that much of a problem for me. Our mailer problems (the tabs replacing stuff) are much more annoying. > * That being said, now that the hwmon subsystem maintainer is a shared > duty between Guenter and myself, there's no single place where we can > keep a patch touching many drivers and ensure it doesn't conflict > with the changes in the other tree. But I would think this is > something for Gunter and myself to sort out, not patch contributors. > > I currently have pending patches to the following hwmon drivers in my > tree: adt7475, ams, asc7621, hdaps, it87, k8temp, lm75, lm85, lm90, > pcf8591, s3c-hwmon, w83795. Two of these are affected by Joe's > patch(es). Guenter, what about you? > coretemp, pkgtemp, via-cputemp, ltc4261 (new), lis3, hp_accel Guenter