public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leandro Lucarella <luca@llucax.com.ar>
To: Jon Maloy <jon.maloy@ericsson.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
	David Miller <davem@davemloft.net>,
	"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tipc-discussion@lists.sourceforge.net" 
	<tipc-discussion@lists.sourceforge.net>
Subject: Re: Linux 2.6.35/TIPC 2.0 ABI breaking changes
Date: Wed, 20 Oct 2010 15:24:11 -0300	[thread overview]
Message-ID: <20101020182411.GO8781@llucax.com.ar> (raw)
In-Reply-To: <0434463FDA60A94FA978ACA44617682DEE84668199@EUSAACMS0702.eamcs.ericsson.se>

Jon Maloy, el 20 de octubre a las 13:57 me escribiste:
> > Another option is to change the TIPC 2.0 specification to use 
> > the old format (use HBO in subscriptions and keep 
> > TIPC_SUB_SERVICE as a separate flag with value 2) and forget 
> > about all this. After all, I can't see what advantages gives 
> > having to change the BO for internal messages between the 
> > applications and the stack.
> 
> I agree with this. I have no problems with changing the draft 
> (which as Leandro already noted is "work-in-progress") to specify that 
> both HBO and NBO are permitted over the wire, and that it is the
> topology server's task to keep track of which one is used.

Just to try to understand better how things works, or are supposed to
work: do the subscription and event messages (and I mean the struct
tipc_subscr and tipc_event published in tipc.h) really go over the wire
or are only used to communicate the stack to the application inside
a node?

I think this is a crucial matter, since it defines if the changes cross
kernel/userspace boundaries only or it also crosses the kernel/network
boundaries.

> Remember, permitting both is a superset of the current one (NBO only)
> so it is fully backwards compatible. We break absolutly nothing by
> permitting this.

I think if they really go through the wire, it should be in NBO, and if
tipc_subscr and tipc_event are used only internally, we can still fix
the userspace messages when sending them through the wire.

In any case, I agree that the patches should be reverted and a solution
should be planned with more time and consensus.

Thanks.

-- 
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
The world's best known word is "okay"
The second most well-known word is "Coca-Cola"

  parent reply	other threads:[~2010-10-20 18:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100927163823.GD2834@integratech.com.ar>
     [not found] ` <29C1DC0826876849BDD9F1C67ABA2943090B67EC@ala-mail09.corp.ad.wrs.com>
     [not found]   ` <20100929153805.GG2834@integratech.com.ar>
     [not found]     ` <29C1DC0826876849BDD9F1C67ABA29430914AC18@ala-mail09.corp.ad.wrs.com>
     [not found]       ` <20101001150034.GS8781@llucax.com.ar>
     [not found]         ` <0434463FDA60A94FA978ACA44617682DEE843EDD79@EUSAACMS0702.eamcs.ericsson.se>
     [not found]           ` <20101001162346.GV8781@llucax.com.ar>
     [not found]             ` <4CA69F18.7000005@amln.net>
     [not found]               ` <0434463FDA60A94FA978ACA44617682DEE8446A03B@EUSAACMS0702.eamcs.ericsson.se>
2010-10-18 15:04                 ` Linux 2.6.35/TIPC 2.0 ABI breaking changes [was: TIPC 2.0 and TIPC_SUB_SERVICE] Leandro Lucarella
2010-10-18 18:46                   ` Leandro Lucarella
2010-10-18 20:42                     ` Paul Gortmaker
2010-10-18 22:17                       ` Linux 2.6.35/TIPC 2.0 ABI breaking changes David Miller
2010-10-18 23:11                         ` Paul Gortmaker
2010-10-18 23:38                           ` Leandro Lucarella
2010-10-18 23:45                           ` Neil Horman
2010-10-19  2:16                             ` Leandro Lucarella
2010-10-19  8:16                               ` David Miller
2010-10-19 11:04                                 ` Neil Horman
2010-10-19 11:06                                   ` David Miller
2010-10-19 13:19                                   ` Leandro Lucarella
2010-10-19 13:28                                     ` Neil Horman
2010-10-19 20:18                                     ` Neil Horman
2010-10-19 20:43                                       ` Leandro Lucarella
2010-10-19 22:03                                         ` Leandro Lucarella
2010-10-20 17:20                                       ` Leandro Lucarella
2010-10-20 17:57                                         ` Jon Maloy
2010-10-20 18:04                                           ` Neil Horman
2010-10-20 18:10                                             ` Jon Maloy
2010-10-20 18:28                                               ` Leandro Lucarella
2010-10-20 19:23                                                 ` Leandro Lucarella
2010-10-20 22:59                                                   ` Leandro Lucarella
2010-10-20 18:24                                           ` Leandro Lucarella [this message]
2010-10-20 18:37                                             ` Jon Maloy
2010-10-20 18:44                                               ` Leandro Lucarella
2010-10-20 17:57                                         ` Neil Horman
2010-10-18 23:58                         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101020182411.GO8781@llucax.com.ar \
    --to=luca@llucax.com.ar \
    --cc=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox