Re: [PATCH -v3 3/6] x86, NMI, Rewrite NMI handler

Huang Ying
2010-10-12T06:54:35Z

On Tue, 2010-10-12 at 14:49 +0800, Peter Zijlstra wrote:
> On Tue, 2010-10-12 at 14:45 +0800, Huang Ying wrote:
> > On Tue, 2010-10-12 at 14:40 +0800, Peter Zijlstra wrote:
> > > On Tue, 2010-10-12 at 14:37 +0800, Huang Ying wrote:
> > > > I just think two die_value make order more explicit.
> > >
> > > I think it sucks, you get to iterate the list twice for no gain.
> >
> > The gain is the code readability. And maybe we can split the list into 2
> > in the future.
>
> No, its not making sense, there's only one event source - the NMI, it
> doesn't make any sense what so ever to then artificially split it in
> two.

They are two steps to process NMI.

Best Regards,
Huang Ying