From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: rklein@nvidia.com, broonie@opensource.wolfsonmicro.com,
achew@nvidia.com, olof@lixom.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] POWER: Add gpio charger driver
Date: Thu, 21 Oct 2010 20:26:17 +0400 [thread overview]
Message-ID: <20101021162617.GA10447@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1287676501-23254-1-git-send-email-lars@metafoo.de>
On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:
> This patch adds a simple driver for chargers indicating their online status
> through a GPIO pin.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Hm. I'm getting older, it seems. Now can anybody remind me why
pda_power.c doesn't work here? ;-)
This driver looks like a light-weigh version of pda_power, except
that it can do GPIOs directly (instead of is_*_online() callbacks).
Can we instead improve pda_power? Like this:
if (!pdata->is_ac_online && pdata->ac_monitor_gpio)
pdata->is_ac_online = pda_ac_monitor_gpio;
Should look quite cool, I think.
(Plus, we might get rid of ac/usb stuff in that driver, and
pass enum power_supply_type to the callbacks instead).
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-10-21 16:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 0:56 [PATCH v2] power: bq24617: Adding initial charger support rklein
2010-10-21 12:20 ` Lars-Peter Clausen
2010-10-21 12:25 ` [PATCH] POWER: Add gpio chager driver Lars-Peter Clausen
2010-10-21 12:43 ` Piotr Hosowicz
2010-10-21 14:53 ` Lars-Peter Clausen
2010-10-21 14:14 ` Anton Vorontsov
2010-10-21 14:52 ` Lars-Peter Clausen
2010-10-21 15:05 ` Anton Vorontsov
2010-10-21 17:22 ` Rhyland Klein
2010-10-21 15:55 ` [PATCH v2] POWER: Add gpio charger driver Lars-Peter Clausen
2010-10-21 16:00 ` Mark Brown
2010-10-21 16:16 ` Lars-Peter Clausen
2010-10-21 16:19 ` Mark Brown
2010-10-21 16:26 ` Anton Vorontsov [this message]
2010-10-21 17:47 ` Lars-Peter Clausen
2010-10-22 21:41 ` Rhyland Klein
2010-10-28 21:17 ` Rhyland Klein
2010-11-04 17:47 ` Anton Vorontsov
2010-11-11 0:53 ` Rhyland Klein
2010-11-11 1:33 ` Lars-Peter Clausen
2010-11-11 1:46 ` Rhyland Klein
2010-11-17 1:37 ` Rhyland Klein
2010-11-18 14:05 ` Anton Vorontsov
2010-11-18 14:30 ` Lars-Peter Clausen
2010-11-18 14:42 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021162617.GA10447@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=achew@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).