From: Arnd Bergmann <arnd@arndb.de>
To: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/3] Coda: remove BKL
Date: Thu, 21 Oct 2010 17:20:28 +0200 [thread overview]
Message-ID: <201010211720.28775.arnd@arndb.de> (raw)
In-Reply-To: <4CC058EC.1060200@cs.cmu.edu>
On Thursday 21 October 2010, Jan Harkes wrote:
> On 10/21/2010 05:08 AM, Arnd Bergmann wrote:
> > On Wednesday 20 October 2010, Jan Harkes wrote:
> >> The following three patches remove the big kernel lock from the Coda
> >> file system kernel module. We initially add a spinlock to protect the
> >> Coda-specific inode data. After this we can push the BKL all the way
> >> down to where the requests are queued for the userspace Coda cache
> >> manager process and finally we replace the remaining BKL uses with a
> >> mutex that protects the upcall queues.
> >
> > Very nice!
> >
> > Are you pushing this to Linus or should I take care of it along with
> > the other file systems?
> >
> > This patch is larger than most of the others, but I can add it to
> > my bkl/vfs tree if you like.
>
> In that case it might be better when pushed separately, just to avoid
> any chances on a merge conflict for the bkl/vfs tree. I was thinking of
> letting the initial merges hit, rebase and retest over the weekend if
> there were any Coda related changes, and sending the final version to
> Linus by monday.
>
> Besides, that gives me a couple of more days to make sure I weed out any
> remaining issues.
Ok, good.
I'll leave everything as is then, to avoid having to rebase myself.
This means you will get the conflict against the pushdown patch into
coda_fill_super, which is trivial to clean up by reverting part of
my patch and applying yours.
Arnd
prev parent reply other threads:[~2010-10-21 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 20:23 [RFC][PATCH 0/3] Coda: remove BKL Jan Harkes
2010-10-20 20:23 ` [RFC][PATCH 1/3] Coda: add spin lock to protect accesses to struct coda_inode_info Jan Harkes
2010-10-20 20:23 ` [RFC][PATCH 2/3] Coda: push BKL regions into coda_upcall() Jan Harkes
2010-10-20 20:23 ` [RFC][PATCH 3/3] Coda: replace BKL with mutex Jan Harkes
2010-10-21 9:08 ` [RFC][PATCH 0/3] Coda: remove BKL Arnd Bergmann
2010-10-21 15:14 ` Jan Harkes
2010-10-21 15:20 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010211720.28775.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox