From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: Greg KH <greg@kroah.com>,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [USB] Allow retrieval of the Caching mode page
Date: Thu, 21 Oct 2010 17:04:05 -0700 [thread overview]
Message-ID: <20101022000405.GC25431@one-eyed-alien.net> (raw)
In-Reply-To: <662065.4331.qm@web31812.mail.mud.yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On Thu, Oct 21, 2010 at 03:52:12PM -0700, Luben Tuikov wrote:
> The statement of the comment removed by this
> patch, "A number of devices have problems with
> MODE SENSE for page x08, so we will skip it" is
> certainly too general to apply for *all*
> devices. This patch removes the unconditional
> retrieval constraint of the Caching mode page.
If you remove this, there are several devices which will stop working.
They will simply go out-to-lunch when the sd_mod driver sends a request for
Mode Page 8.
Matt
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
I want my GPFs!!!
-- Stef
User Friendly, 11/9/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-10-22 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 22:52 [PATCH] [USB] Allow retrieval of the Caching mode page Luben Tuikov
2010-10-22 0:04 ` Matthew Dharm [this message]
2010-10-22 4:06 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022000405.GC25431@one-eyed-alien.net \
--to=mdharm-kernel@one-eyed-alien.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox