Re: [PATCH 06/21] fs: Clean up inode reference counting

Christoph Hellwig
2010-10-21T01:42:44Z

> diff --git a/fs/nfs/write.c b/fs/nfs/write.c
> index 874972d..d1c2f08 100644
> --- a/fs/nfs/write.c
> +++ b/fs/nfs/write.c
> @@ -390,7 +390,7 @@ static int nfs_inode_add_request(struct inode *inode, struct nfs_page *req)
> error = radix_tree_insert(&nfsi->nfs_page_tree, req->wb_index, req);
> BUG_ON(error);
> if (!nfsi->npages) {
> - igrab(inode);
> + iref(inode);
> if (nfs_have_delegation(inode, FMODE_WRITE))
> nfsi->change_attr++;

This still needs to be an unlocked increment, as point out in reply to
the last iteration.