* linux-next: next-20101022 broken with unset CONFIG_BKL
@ 2010-10-22 9:13 Sedat Dilek
2010-10-22 9:24 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2010-10-22 9:13 UTC (permalink / raw)
To: LKML; +Cc: Arnd Bergmann, sfr
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
Hi,
I am trying to compile latest linux-next with unset CONFIG_BKL.
Yes, one patch is missing from [1] to be able to compile a BKL-free kernel.
(BTW, the patch needs a trivial fix, see v2 attached to this email.)
With next-20101022 the build breaks (sorry for the output in German):
[ build.log ]
...
LD [M] fs/ceph/ceph.o
LD fs/coda/built-in.o
CC [M] fs/coda/psdev.o
CC [M] fs/cifs/misc.o
/home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:
In function ‘coda_psdev_write’:
/home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:140:
error: implicit declaration of function ‘lock_kernel’
/home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:142:
error: implicit declaration of function ‘unlock_kernel’
CC block/blk-settings.o
make[6]: *** [fs/coda/psdev.o] Fehler 1
make[5]: *** [fs/coda] Fehler 2
make[5]: *** Warte auf noch nicht beendete Prozesse...
...
Just FYI.
Kind Regards,
- Sedat -
[1] https://patchwork.kernel.org/patch/262561/
[-- Attachment #2: fs-remove-BKL-from-FILE_LOCKING-v2.patch --]
[-- Type: text/plain, Size: 2155 bytes --]
From patchwork Mon Oct 18 17:38:26 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [v2] Remaining BKL users, what to do
Date: Mon, 18 Oct 2010 17:38:26 -0000
From: Arnd Bergmann <arnd@arndb.de>
X-Patchwork-Id: 262561
Message-Id: <201010181938.27076.arnd@arndb.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: codalist@TELEMANN.coda.cs.cmu.edu,
ksummit-2010-discuss@lists.linux-foundation.org,
autofs@linux.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Petr Vandrovec <vandrove@vc.cvut.cz>, Anders Larsen <al@alarsen.net>,
Jan Kara <jack@suse.cz>, Evgeniy Dushistov <dushistov@mail.ru>,
Ingo Molnar <mingo@elte.hu>, netdev@vger.kernel.org,
Samuel Ortiz <samuel@sortiz.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Hendry <andrew.hendry@gmail.com>,
David Miller <davem@davemloft.net>, Jan Harkes <jaharkes@cs.cmu.edu>,
Bryan Schumaker <bjschuma@netapp.com>
diff --git a/fs/Kconfig b/fs/Kconfig
index c386a9f..25ce2dc 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -50,7 +50,6 @@ endif # BLOCK
config FILE_LOCKING
bool "Enable POSIX file locking API" if EMBEDDED
default y
- select BKL # while lockd still uses it.
help
This option enables standard file locking support, required
for filesystems like NFS and for the flock() system
diff --git a/fs/locks.c b/fs/locks.c
index 8b2b6ad..02b6e0e 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -142,6 +142,7 @@ int lease_break_time = 45;
static LIST_HEAD(file_lock_list);
static LIST_HEAD(blocked_list);
+static DEFINE_SPINLOCK(file_lock_lock);
/*
* Protects the two list heads above, plus the inode->i_flock list
@@ -149,13 +150,13 @@ static LIST_HEAD(blocked_list);
*/
void lock_flocks(void)
{
- lock_kernel();
+ spin_lock(&file_lock_lock);
}
EXPORT_SYMBOL_GPL(lock_flocks);
void unlock_flocks(void)
{
- unlock_kernel();
+ spin_unlock(&file_lock_lock);
}
EXPORT_SYMBOL_GPL(unlock_flocks);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: next-20101022 broken with unset CONFIG_BKL
2010-10-22 9:13 linux-next: next-20101022 broken with unset CONFIG_BKL Sedat Dilek
@ 2010-10-22 9:24 ` Arnd Bergmann
2010-10-22 9:30 ` Sedat Dilek
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2010-10-22 9:24 UTC (permalink / raw)
To: sedat.dilek; +Cc: LKML, sfr, Jan Harkes
On Friday 22 October 2010 11:13:23 Sedat Dilek wrote:
> Hi,
>
> I am trying to compile latest linux-next with unset CONFIG_BKL.
> Yes, one patch is missing from [1] to be able to compile a BKL-free kernel.
> (BTW, the patch needs a trivial fix, see v2 attached to this email.)
>
> With next-20101022 the build breaks (sorry for the output in German):
>
> [ build.log ]
> ...
> LD [M] fs/ceph/ceph.o
> LD fs/coda/built-in.o
> CC [M] fs/coda/psdev.o
> CC [M] fs/cifs/misc.o
> /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:
> In function ‘coda_psdev_write’:
> /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:140:
> error: implicit declaration of function ‘lock_kernel’
> /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:142:
> error: implicit declaration of function ‘unlock_kernel’
> CC block/blk-settings.o
> make[6]: *** [fs/coda/psdev.o] Fehler 1
> make[5]: *** [fs/coda] Fehler 2
> make[5]: *** Warte auf noch nicht beendete Prozesse...
> ...
>
> Just FYI.
>
Ok, thanks for the report. There is a patch for coda to remove the BKL.
We discussed it yesterday and I subsequently removed the switch that
disables it on non-BKL configs.
We then agreed to not have the patch included in my series, and Jan's
tree is not part of linux-next.
There are more of these in mainline once Linus pulls my tree, but that
just means that we need to get all the other trees into -rc1 that
remove the BKL from other subsystems, before applying the patch that
lets you build with CONFIG_FILE_LOCKING=y and CONFIG_BKL=n.
Right now, both allyesconfig (with BKL) and allnoconfig (without coda)
work fine, we only get a few really obscure randconfigs breaking.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: next-20101022 broken with unset CONFIG_BKL
2010-10-22 9:24 ` Arnd Bergmann
@ 2010-10-22 9:30 ` Sedat Dilek
2010-10-22 9:36 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2010-10-22 9:30 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: LKML, sfr, Jan Harkes
On Fri, Oct 22, 2010 at 11:24 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 22 October 2010 11:13:23 Sedat Dilek wrote:
>> Hi,
>>
>> I am trying to compile latest linux-next with unset CONFIG_BKL.
>> Yes, one patch is missing from [1] to be able to compile a BKL-free kernel.
>> (BTW, the patch needs a trivial fix, see v2 attached to this email.)
>>
>> With next-20101022 the build breaks (sorry for the output in German):
>>
>> [ build.log ]
>> ...
>> LD [M] fs/ceph/ceph.o
>> LD fs/coda/built-in.o
>> CC [M] fs/coda/psdev.o
>> CC [M] fs/cifs/misc.o
>> /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:
>> In function ‘coda_psdev_write’:
>> /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:140:
>> error: implicit declaration of function ‘lock_kernel’
>> /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/coda/psdev.c:142:
>> error: implicit declaration of function ‘unlock_kernel’
>> CC block/blk-settings.o
>> make[6]: *** [fs/coda/psdev.o] Fehler 1
>> make[5]: *** [fs/coda] Fehler 2
>> make[5]: *** Warte auf noch nicht beendete Prozesse...
>> ...
>>
>> Just FYI.
>>
>
> Ok, thanks for the report. There is a patch for coda to remove the BKL.
> We discussed it yesterday and I subsequently removed the switch that
> disables it on non-BKL configs.
>
> We then agreed to not have the patch included in my series, and Jan's
> tree is not part of linux-next.
>
> There are more of these in mainline once Linus pulls my tree, but that
> just means that we need to get all the other trees into -rc1 that
> remove the BKL from other subsystems, before applying the patch that
> lets you build with CONFIG_FILE_LOCKING=y and CONFIG_BKL=n.
>
> Right now, both allyesconfig (with BKL) and allnoconfig (without coda)
> work fine, we only get a few really obscure randconfigs breaking.
>
> Arnd
>
Wow, you answer in realtime :-), Arnd.
Thanks for the explanations and I agree with you to wait for 27-rc1
and then to remove BKL.
Me just doing early-testing...
A pointer to the patch?
Thanks in advance.
- Sedat -
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: next-20101022 broken with unset CONFIG_BKL
2010-10-22 9:30 ` Sedat Dilek
@ 2010-10-22 9:36 ` Arnd Bergmann
2010-10-22 11:34 ` Sedat Dilek
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2010-10-22 9:36 UTC (permalink / raw)
To: sedat.dilek; +Cc: LKML, sfr, Jan Harkes
On Friday 22 October 2010 11:30:17 Sedat Dilek wrote:
> Wow, you answer in realtime :-), Arnd.
> Thanks for the explanations and I agree with you to wait for 27-rc1
> and then to remove BKL.
> Me just doing early-testing...
>
> A pointer to the patch?
> Thanks in advance.
The thread is "Coda: remove BKL", You can find it on patchwork.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: next-20101022 broken with unset CONFIG_BKL
2010-10-22 9:36 ` Arnd Bergmann
@ 2010-10-22 11:34 ` Sedat Dilek
2010-10-22 16:03 ` Sedat Dilek
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2010-10-22 11:34 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: LKML, sfr, Jan Harkes
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
On Fri, Oct 22, 2010 at 11:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 22 October 2010 11:30:17 Sedat Dilek wrote:
>
>> Wow, you answer in realtime :-), Arnd.
>> Thanks for the explanations and I agree with you to wait for 27-rc1
>> and then to remove BKL.
>> Me just doing early-testing...
>>
>> A pointer to the patch?
>> Thanks in advance.
>
> The thread is "Coda: remove BKL", You can find it on patchwork.
>
> Arnd
>
Yeah, I found the triple patch-series, but #3 does not apply, here is
a v2 for that.
Please have a look at it, Thanks.
[ debian/changelog ]
...
* debian/patches/for-linux-next/coda-fixes:
- RFC-1-3-Coda-add-spin-lock-to-protect-accesses-to-struct-coda_inode_info.patch
(Patch from <https://patchwork.kernel.org/patch/269131/>)
- RFC-2-3-Coda-push-BKL-regions-into-coda_upcall.patch
(Patch from <https://patchwork.kernel.org/patch/269141/>)
- RFC-3-3-Coda-replace-BKL-with-mutex-v2.patch (refreshed)
(Patch from <https://patchwork.kernel.org/patch/269151/>)
...
Applying OK, but not compile-tested, yet.
- Sedat -
[-- Attachment #2: RFC-3-3-Coda-replace-BKL-with-mutex-v2.patch --]
[-- Type: text/plain, Size: 8756 bytes --]
From patchwork Wed Oct 20 20:23:04 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [RFC,3/3] Coda: replace BKL with mutex
Date: Wed, 20 Oct 2010 20:23:04 -0000
From: Jan Harkes <jaharkes@cs.cmu.edu>
X-Patchwork-Id: 269151
Message-Id: <1287606184-26889-4-git-send-email-jaharkes@cs.cmu.edu>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
Yoshihisa Abe <yoshiabe@cs.cmu.edu>, Jan Harkes <jaharkes@cs.cmu.edu>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
v2:
* Adapt to fit to linux-next (next-20101022)
* fs/coda/inode.c: Remove lock_kernel() and unlock_kernel() relicts
Index: linux-2.6/fs/coda/inode.c
===================================================================
--- linux-2.6.orig/fs/coda/inode.c
+++ linux-2.6/fs/coda/inode.c
@@ -15,6 +15,7 @@
#include <linux/stat.h>
#include <linux/errno.h>
#include <linux/unistd.h>
+#include <linux/mutex.h>
#include <linux/spinlock.h>
#include <linux/file.h>
#include <linux/vfs.h>
@@ -144,13 +145,11 @@ static int get_device_index(struct coda_
static int coda_fill_super(struct super_block *sb, void *data, int silent)
{
struct inode *root = NULL;
- struct venus_comm *vc = NULL;
+ struct venus_comm *vc;
struct CodaFid fid;
int error;
int idx;
- lock_kernel();
-
idx = get_device_index((struct coda_mount_data *) data);
/* Ignore errors in data, for backward compatibility */
@@ -160,23 +159,26 @@ static int coda_fill_super(struct super_
printk(KERN_INFO "coda_read_super: device index: %i\n", idx);
vc = &coda_comms[idx];
+ mutex_lock(&vc->vc_mutex);
+
if (!vc->vc_inuse) {
printk("coda_read_super: No pseudo device\n");
- unlock_kernel();
- return -EINVAL;
+ error = -EINVAL;
+ goto unlock_out;
}
if ( vc->vc_sb ) {
printk("coda_read_super: Device already mounted\n");
- unlock_kernel();
- return -EBUSY;
+ error = -EBUSY;
+ goto unlock_out;
}
error = bdi_setup_and_register(&vc->bdi, "coda", BDI_CAP_MAP_COPY);
if (error)
- goto bdi_err;
+ goto unlock_out;
vc->vc_sb = sb;
+ mutex_unlock(&vc->vc_mutex);
sb->s_fs_info = vc;
sb->s_flags |= MS_NOATIME;
@@ -205,28 +207,36 @@ static int coda_fill_super(struct super_
printk("coda_read_super: rootinode is %ld dev %s\n",
root->i_ino, root->i_sb->s_id);
sb->s_root = d_alloc_root(root);
- if (!sb->s_root)
+ if (!sb->s_root) {
+ error = -EINVAL;
goto error;
- unlock_kernel();
+ }
return 0;
- error:
- bdi_destroy(&vc->bdi);
- bdi_err:
+error:
if (root)
iput(root);
- if (vc)
- vc->vc_sb = NULL;
- unlock_kernel();
- return -EINVAL;
+ mutex_lock(&vc->vc_mutex);
+ bdi_destroy(&vc->bdi);
+ vc->vc_sb = NULL;
+ sb->s_fs_info = NULL;
+ mutex_unlock(&vc->vc_mutex);
+ return error;
+
+unlock_out:
+ mutex_unlock(&vc->vc_mutex);
+ return error;
}
static void coda_put_super(struct super_block *sb)
{
- bdi_destroy(&coda_vcp(sb)->bdi);
- coda_vcp(sb)->vc_sb = NULL;
+ struct venus_comm *vcp = coda_vcp(sb);
+ mutex_lock(&vcp->vc_mutex);
+ bdi_destroy(&vcp->bdi);
+ vcp->vc_sb = NULL;
sb->s_fs_info = NULL;
+ mutex_unlock(&vcp->vc_mutex);
printk("Coda: Bye bye.\n");
}
diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c
index f786759..d815c24 100644
--- a/fs/coda/psdev.c
+++ b/fs/coda/psdev.c
@@ -35,7 +35,7 @@
#include <linux/poll.h>
#include <linux/init.h>
#include <linux/list.h>
-#include <linux/smp_lock.h>
+#include <linux/mutex.h>
#include <linux/device.h>
#include <asm/io.h>
#include <asm/system.h>
@@ -67,8 +67,10 @@ static unsigned int coda_psdev_poll(struct file *file, poll_table * wait)
unsigned int mask = POLLOUT | POLLWRNORM;
poll_wait(file, &vcp->vc_waitq, wait);
+ mutex_lock(&vcp->vc_mutex);
if (!list_empty(&vcp->vc_pending))
mask |= POLLIN | POLLRDNORM;
+ mutex_unlock(&vcp->vc_mutex);
return mask;
}
@@ -150,7 +152,7 @@ static ssize_t coda_psdev_write(struct file *file, const char __user *buf,
}
/* Look for the message on the processing queue. */
- lock_kernel();
+ mutex_lock(&vcp->vc_mutex);
list_for_each(lh, &vcp->vc_processing) {
tmp = list_entry(lh, struct upc_req , uc_chain);
if (tmp->uc_unique == hdr.unique) {
@@ -159,7 +161,7 @@ static ssize_t coda_psdev_write(struct file *file, const char __user *buf,
break;
}
}
- unlock_kernel();
+ mutex_unlock(&vcp->vc_mutex);
if (!req) {
printk("psdev_write: msg (%d, %d) not found\n",
@@ -214,7 +216,7 @@ static ssize_t coda_psdev_read(struct file * file, char __user * buf,
if (nbytes == 0)
return 0;
- lock_kernel();
+ mutex_lock(&vcp->vc_mutex);
add_wait_queue(&vcp->vc_waitq, &wait);
set_current_state(TASK_INTERRUPTIBLE);
@@ -228,7 +230,9 @@ static ssize_t coda_psdev_read(struct file * file, char __user * buf,
retval = -ERESTARTSYS;
break;
}
+ mutex_unlock(&vcp->vc_mutex);
schedule();
+ mutex_lock(&vcp->vc_mutex);
}
set_current_state(TASK_RUNNING);
@@ -261,7 +265,7 @@ static ssize_t coda_psdev_read(struct file * file, char __user * buf,
CODA_FREE(req->uc_data, sizeof(struct coda_in_hdr));
kfree(req);
out:
- unlock_kernel();
+ mutex_unlock(&vcp->vc_mutex);
return (count ? count : retval);
}
@@ -274,10 +278,10 @@ static int coda_psdev_open(struct inode * inode, struct file * file)
if (idx < 0 || idx >= MAX_CODADEVS)
return -ENODEV;
- lock_kernel();
-
err = -EBUSY;
vcp = &coda_comms[idx];
+ mutex_lock(&vcp->vc_mutex);
+
if (!vcp->vc_inuse) {
vcp->vc_inuse++;
@@ -291,7 +295,7 @@ static int coda_psdev_open(struct inode * inode, struct file * file)
err = 0;
}
- unlock_kernel();
+ mutex_unlock(&vcp->vc_mutex);
return err;
}
@@ -306,7 +310,7 @@ static int coda_psdev_release(struct inode * inode, struct file * file)
return -1;
}
- lock_kernel();
+ mutex_lock(&vcp->vc_mutex);
/* Wakeup clients so they can return. */
list_for_each_entry_safe(req, tmp, &vcp->vc_pending, uc_chain) {
@@ -331,7 +335,7 @@ static int coda_psdev_release(struct inode * inode, struct file * file)
file->private_data = NULL;
vcp->vc_inuse--;
- unlock_kernel();
+ mutex_unlock(&vcp->vc_mutex);
return 0;
}
@@ -359,9 +363,11 @@ static int init_coda_psdev(void)
err = PTR_ERR(coda_psdev_class);
goto out_chrdev;
}
- for (i = 0; i < MAX_CODADEVS; i++)
+ for (i = 0; i < MAX_CODADEVS; i++) {
+ mutex_init(&(&coda_comms[i])->vc_mutex);
device_create(coda_psdev_class, NULL,
MKDEV(CODA_PSDEV_MAJOR, i), NULL, "cfs%d", i);
+ }
coda_sysctl_init();
goto out;
diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
index e53847f..e41b906 100644
--- a/fs/coda/upcall.c
+++ b/fs/coda/upcall.c
@@ -27,7 +27,7 @@
#include <linux/errno.h>
#include <linux/string.h>
#include <linux/slab.h>
-#include <linux/smp_lock.h>
+#include <linux/mutex.h>
#include <asm/uaccess.h>
#include <linux/vmalloc.h>
#include <linux/vfs.h>
@@ -607,7 +607,8 @@ static void coda_unblock_signals(sigset_t *old)
(r)->uc_opcode != CODA_RELEASE) || \
(r)->uc_flags & CODA_REQ_READ))
-static inline void coda_waitfor_upcall(struct upc_req *req)
+static inline void coda_waitfor_upcall(struct venus_comm *vcp,
+ struct upc_req *req)
{
DECLARE_WAITQUEUE(wait, current);
unsigned long timeout = jiffies + coda_timeout * HZ;
@@ -640,10 +641,12 @@ static inline void coda_waitfor_upcall(struct upc_req *req)
break;
}
+ mutex_unlock(&vcp->vc_mutex);
if (blocked)
schedule_timeout(HZ);
else
schedule();
+ mutex_lock(&vcp->vc_mutex);
}
if (blocked)
coda_unblock_signals(&old);
@@ -671,7 +674,7 @@ static int coda_upcall(struct venus_comm *vcp,
struct upc_req *req = NULL, *sig_req;
int error;
- lock_kernel();
+ mutex_lock(&vcp->vc_mutex);
if (!vcp->vc_inuse) {
printk(KERN_NOTICE "coda: Venus dead, not sending upcall\n");
@@ -711,7 +714,7 @@ static int coda_upcall(struct venus_comm *vcp,
* ENODEV. */
/* Go to sleep. Wake up on signals only after the timeout. */
- coda_waitfor_upcall(req);
+ coda_waitfor_upcall(vcp, req);
/* Op went through, interrupt or not... */
if (req->uc_flags & CODA_REQ_WRITE) {
@@ -765,7 +768,7 @@ static int coda_upcall(struct venus_comm *vcp,
exit:
kfree(req);
- unlock_kernel();
+ mutex_unlock(&vcp->vc_mutex);
return error;
}
diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
index 284b520..42a8229 100644
--- a/include/linux/coda_psdev.h
+++ b/include/linux/coda_psdev.h
@@ -8,6 +8,7 @@
#ifdef __KERNEL__
#include <linux/backing-dev.h>
+#include <linux/mutex.h>
struct kstatfs;
@@ -20,6 +21,7 @@ struct venus_comm {
int vc_inuse;
struct super_block *vc_sb;
struct backing_dev_info bdi;
+ struct mutex vc_mutex;
};
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: next-20101022 broken with unset CONFIG_BKL
2010-10-22 11:34 ` Sedat Dilek
@ 2010-10-22 16:03 ` Sedat Dilek
0 siblings, 0 replies; 6+ messages in thread
From: Sedat Dilek @ 2010-10-22 16:03 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: LKML, sfr, Jan Harkes
On Fri, Oct 22, 2010 at 1:34 PM, Sedat Dilek <sedat.dilek@googlemail.com> wrote:
> On Fri, Oct 22, 2010 at 11:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Friday 22 October 2010 11:30:17 Sedat Dilek wrote:
>>
>>> Wow, you answer in realtime :-), Arnd.
>>> Thanks for the explanations and I agree with you to wait for 27-rc1
>>> and then to remove BKL.
>>> Me just doing early-testing...
>>>
>>> A pointer to the patch?
>>> Thanks in advance.
>>
>> The thread is "Coda: remove BKL", You can find it on patchwork.
>>
>> Arnd
>>
>
> Yeah, I found the triple patch-series, but #3 does not apply, here is
> a v2 for that.
>
> Please have a look at it, Thanks.
>
> [ debian/changelog ]
> ...
> * debian/patches/for-linux-next/coda-fixes:
> - RFC-1-3-Coda-add-spin-lock-to-protect-accesses-to-struct-coda_inode_info.patch
> (Patch from <https://patchwork.kernel.org/patch/269131/>)
> - RFC-2-3-Coda-push-BKL-regions-into-coda_upcall.patch
> (Patch from <https://patchwork.kernel.org/patch/269141/>)
> - RFC-3-3-Coda-replace-BKL-with-mutex-v2.patch (refreshed)
> (Patch from <https://patchwork.kernel.org/patch/269151/>)
> ...
>
> Applying OK, but not compile-tested, yet.
>
> - Sedat -
>
Compilation was successful.
# modinfo coda
filename: /lib/modules/2.6.36-next-20101022.1-686/kernel/fs/coda/coda.ko
version: 6.6
license: GPL
alias: char-major-67-*
description: Coda Distributed File System VFS interface
author: Jan Harkes, Peter J. Braam
srcversion: AB8F3FBC43B1EBA43CEDEE5
depends:
vermagic: 2.6.36-next-20101022.1-686 SMP mod_unload modversions 686
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-22 16:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-22 9:13 linux-next: next-20101022 broken with unset CONFIG_BKL Sedat Dilek
2010-10-22 9:24 ` Arnd Bergmann
2010-10-22 9:30 ` Sedat Dilek
2010-10-22 9:36 ` Arnd Bergmann
2010-10-22 11:34 ` Sedat Dilek
2010-10-22 16:03 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox