From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Luca Barbieri <luca@luca-barbieri.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/atomic64_test: do not build on non-atomic64 systems
Date: Fri, 22 Oct 2010 13:31:38 -0700 [thread overview]
Message-ID: <20101022133138.6d82f79a.akpm@linux-foundation.org> (raw)
In-Reply-To: <AANLkTikGbK7=eW9L4A62Rin-E3usq4Ke_dPoCdStDyEw@mail.gmail.com>
On Fri, 22 Oct 2010 16:14:49 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> On Thu, Oct 21, 2010 at 19:24, Andrew Morton wrote:
> > On Thu, 21 Oct 2010 19:04:36 -0400 Mike Frysinger wrote:
> >> you can say "lazy" all you like. __i dont see the point in going that route.
> >
> > Try
> >
> > __ __ __ __grep HAVE arch/x86/Kconfig
> >
> > If all of those were instead to use some random #define which the
> > particular feature happened to define in some header file then we would
> > have a mess on our hands.
>
> fun times. new tact.
>
> Luca: your new atomic64_t test build fails on all arches that lack
> atomic64_t. please fix.
That's only part of the problem. The following won't build also:
net/rds
kernel/perf_event.c
drivers/staging/octeon
drivers/infiniband/hw
with more to come. These things should be made dependent upon
CONFIG_HAVE_ATOMIC64 in Kconfig. (Can't use #ifdef ATOMIC64_INIT for this!)
Or, much better, we implement atomic64 on the offending architectures.
next prev parent reply other threads:[~2010-10-22 20:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 17:27 [PATCH] lib/atomic64_test: do not build on non-atomic64 systems Mike Frysinger
2010-10-21 22:02 ` Andrew Morton
2010-10-21 22:23 ` Mike Frysinger
2010-10-21 22:55 ` Andrew Morton
2010-10-21 23:04 ` Mike Frysinger
2010-10-21 23:24 ` Andrew Morton
2010-10-22 20:14 ` Mike Frysinger
2010-10-22 20:31 ` Andrew Morton [this message]
2010-10-22 20:47 ` Mike Frysinger
2010-10-22 21:00 ` Andrew Morton
2010-10-22 21:07 ` Mike Frysinger
2010-10-24 16:20 ` Roland Dreier
2010-10-25 1:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022133138.6d82f79a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@luca-barbieri.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox