* [PATCH RESEND] drm: include missing types header to drm_mode.h @ 2010-10-22 13:13 Davidlohr Bueso 2010-10-22 23:55 ` Andrew Morton 0 siblings, 1 reply; 5+ messages in thread From: Davidlohr Bueso @ 2010-10-22 13:13 UTC (permalink / raw) To: Dave Airlie, Dave Airlie; +Cc: LKML, dri-devel drm: include missing types header to drm_mode.h Signed-off-by: Davidlohr Bueso <dave@gnu.org> --- include/drm/drm_mode.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@ * IN THE SOFTWARE. */ +#include <linux/types.h> + #ifndef _DRM_MODE_H #define _DRM_MODE_H -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm: include missing types header to drm_mode.h 2010-10-22 13:13 [PATCH RESEND] drm: include missing types header to drm_mode.h Davidlohr Bueso @ 2010-10-22 23:55 ` Andrew Morton 2010-10-23 0:02 ` Randy Dunlap 0 siblings, 1 reply; 5+ messages in thread From: Andrew Morton @ 2010-10-22 23:55 UTC (permalink / raw) To: dave; +Cc: Dave Airlie, Dave Airlie, LKML, dri-devel On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso <dave@gnu.org> wrote: > drm: include missing types header to drm_mode.h > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > --- > include/drm/drm_mode.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h > index 0fc7397..eddd7f4 100644 > --- a/include/drm/drm_mode.h > +++ b/include/drm/drm_mode.h > @@ -24,6 +24,8 @@ > * IN THE SOFTWARE. > */ > > +#include <linux/types.h> > + > #ifndef _DRM_MODE_H > #define _DRM_MODE_H > Does this fix a build error? If so, please send along the compiler error output. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm: include missing types header to drm_mode.h 2010-10-22 23:55 ` Andrew Morton @ 2010-10-23 0:02 ` Randy Dunlap 2010-10-23 0:19 ` Dave Airlie 2010-10-25 2:13 ` Davidlohr Bueso 0 siblings, 2 replies; 5+ messages in thread From: Randy Dunlap @ 2010-10-23 0:02 UTC (permalink / raw) To: Andrew Morton; +Cc: dave, Dave Airlie, Dave Airlie, LKML, dri-devel On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote: > On Fri, 22 Oct 2010 10:13:19 -0300 > Davidlohr Bueso <dave@gnu.org> wrote: > > > drm: include missing types header to drm_mode.h > > > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > > --- > > include/drm/drm_mode.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h > > index 0fc7397..eddd7f4 100644 > > --- a/include/drm/drm_mode.h > > +++ b/include/drm/drm_mode.h > > @@ -24,6 +24,8 @@ > > * IN THE SOFTWARE. > > */ > > > > +#include <linux/types.h> > > + > > #ifndef _DRM_MODE_H > > #define _DRM_MODE_H > > > > Does this fix a build error? If so, please send along the compiler > error output. Every build that has CONFIG_HEADERS_CHECK=y reports the following: linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h> --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm: include missing types header to drm_mode.h 2010-10-23 0:02 ` Randy Dunlap @ 2010-10-23 0:19 ` Dave Airlie 2010-10-25 2:13 ` Davidlohr Bueso 1 sibling, 0 replies; 5+ messages in thread From: Dave Airlie @ 2010-10-23 0:19 UTC (permalink / raw) To: Randy Dunlap Cc: Andrew Morton, dave, Dave Airlie, Dave Airlie, LKML, dri-devel On Sat, Oct 23, 2010 at 10:02 AM, Randy Dunlap <rdunlap@xenotime.net> wrote: > On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote: > >> On Fri, 22 Oct 2010 10:13:19 -0300 >> Davidlohr Bueso <dave@gnu.org> wrote: >> >> > drm: include missing types header to drm_mode.h >> > >> > Signed-off-by: Davidlohr Bueso <dave@gnu.org> >> > --- >> > include/drm/drm_mode.h | 2 ++ >> > 1 files changed, 2 insertions(+), 0 deletions(-) >> > >> > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h >> > index 0fc7397..eddd7f4 100644 >> > --- a/include/drm/drm_mode.h >> > +++ b/include/drm/drm_mode.h >> > @@ -24,6 +24,8 @@ >> > * IN THE SOFTWARE. >> > */ >> > >> > +#include <linux/types.h> >> > + >> > #ifndef _DRM_MODE_H >> > #define _DRM_MODE_H >> > >> >> Does this fix a build error? If so, please send along the compiler >> error output. > > > Every build that has CONFIG_HEADERS_CHECK=y reports the following: > > linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h> > > Why doesn't the tool understand header recursion? drm_mode.h needs to include drm.h but the rest already include drm.h. Including drm.h includes linux/types.h if defined(__linux__) So really I've said this a few times now, its the stupid tool that is broken for most of these, fix the tool and I'll fix drm_mode.h Dave. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm: include missing types header to drm_mode.h 2010-10-23 0:02 ` Randy Dunlap 2010-10-23 0:19 ` Dave Airlie @ 2010-10-25 2:13 ` Davidlohr Bueso 1 sibling, 0 replies; 5+ messages in thread From: Davidlohr Bueso @ 2010-10-25 2:13 UTC (permalink / raw) To: Randy Dunlap; +Cc: Andrew Morton, Dave Airlie, Dave Airlie, LKML, dri-devel On Fri, 2010-10-22 at 17:02 -0700, Randy Dunlap wrote: > On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote: > > > On Fri, 22 Oct 2010 10:13:19 -0300 > > Davidlohr Bueso <dave@gnu.org> wrote: > > > > > drm: include missing types header to drm_mode.h > > > > > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > > > --- > > > include/drm/drm_mode.h | 2 ++ > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h > > > index 0fc7397..eddd7f4 100644 > > > --- a/include/drm/drm_mode.h > > > +++ b/include/drm/drm_mode.h > > > @@ -24,6 +24,8 @@ > > > * IN THE SOFTWARE. > > > */ > > > > > > +#include <linux/types.h> > > > + > > > #ifndef _DRM_MODE_H > > > #define _DRM_MODE_H > > > > > > > Does this fix a build error? If so, please send along the compiler > > error output. > > > Every build that has CONFIG_HEADERS_CHECK=y reports the following: > > linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h> > linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h> > Yeah that's what made me send the patch. Thanks, Davidlohr ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-25 2:13 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-10-22 13:13 [PATCH RESEND] drm: include missing types header to drm_mode.h Davidlohr Bueso 2010-10-22 23:55 ` Andrew Morton 2010-10-23 0:02 ` Randy Dunlap 2010-10-23 0:19 ` Dave Airlie 2010-10-25 2:13 ` Davidlohr Bueso
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox