From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758034Ab0JVRV0 (ORCPT ); Fri, 22 Oct 2010 13:21:26 -0400 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:62556 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754545Ab0JVRVZ (ORCPT ); Fri, 22 Oct 2010 13:21:25 -0400 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 67.188.36.105 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19B2XxgEPk8B7mZ2Hu7Y+Ze Date: Fri, 22 Oct 2010 10:21:20 -0700 From: Tony Lindgren To: Tim Nordell Cc: "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARM: OMAP: Modified omap_mux_init_signal() to take in const char * Message-ID: <20101022172120.GH9149@atomide.com> References: <1287687041-22377-1-git-send-email-tim.nordell@logicpd.com> <4CC09042.3000201@logicpd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CC09042.3000201@logicpd.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tim Nordell [101021 12:02]: > On 10/21/10 13:50, Tim Nordell wrote: > > It looks like by inspection that there could be a couple of things wrong > with that patch however. Namely, on the comparison of muxname to > m0_entry, if they have the same string up to mode0_len, such as > "dss_data1" and "dss_data12" it'd match there prematurely as it'd stop > comparing. Also, a minor display issue on the printk of the new muxname. Good catch, it would be nice to get those fixed too. Got any patches for those issues? Regards, Tony