* [PATCH] pcmcia/cm4000: fix error code
@ 2010-10-22 16:10 Nicolas Kaiser
2010-10-26 16:23 ` Harald Welte
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Kaiser @ 2010-10-22 16:10 UTC (permalink / raw)
To: Harald Welte; +Cc: linux-kernel
I'm assuming it's not intended to instantly change the error code
from -ENODEV to -EIO, is it?
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/char/pcmcia/cm4000_cs.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c
index d962f25..777181a 100644
--- a/drivers/char/pcmcia/cm4000_cs.c
+++ b/drivers/char/pcmcia/cm4000_cs.c
@@ -979,8 +979,9 @@ static ssize_t cmm_read(struct file *filp, __user char *buf, size_t count,
if (dev->flags0 & 1) {
set_bit(IS_CMM_ABSENT, &dev->flags);
rc = -ENODEV;
+ } else {
+ rc = -EIO;
}
- rc = -EIO;
goto release_io;
}
--
1.7.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pcmcia/cm4000: fix error code
2010-10-22 16:10 [PATCH] pcmcia/cm4000: fix error code Nicolas Kaiser
@ 2010-10-26 16:23 ` Harald Welte
0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2010-10-26 16:23 UTC (permalink / raw)
To: Nicolas Kaiser; +Cc: linux-kernel
On Fri, Oct 22, 2010 at 06:10:24PM +0200, Nicolas Kaiser wrote:
> I'm assuming it's not intended to instantly change the error code
> from -ENODEV to -EIO, is it?
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-by: Harald Welte <laforge@gnumonks.org>
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-26 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-22 16:10 [PATCH] pcmcia/cm4000: fix error code Nicolas Kaiser
2010-10-26 16:23 ` Harald Welte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox