From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: axboe@kernel.dk, akpm@linux-foundation.org, smcameron@yahoo.com,
linux-kernel@vger.kernel.org, mike.miller@hp.com,
thenzl@redhat.com
Subject: Re: [PATCH 1/5] cciss: remove controllers supported by hpsa
Date: Fri, 22 Oct 2010 21:46:43 +0200 [thread overview]
Message-ID: <20101022214643.61dcafdd@neptune.home> (raw)
In-Reply-To: <20101022192101.25567.40578.stgit@beardog.cce.hp.com>
On Fri, 22 October 2010 "Stephen M. Cameron" wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> We would prefer not to have any overlap between the two drivers.
> Remove the cciss_allow_hpsa option, as it it is no longer needed.
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
I think it would be helpful to provide clear indication in cciss'
Kconfig description about which controllers are the last ones to be
supported by cciss and starting from which ones hpsa is needed.
In addition the dev_warn before returning -ENODEV could include a
hint that newish controllers need hpsa driver instead of just saying
"unrecognized board ...", this at least when hpsa driver was not
included in kernel build.
Regards,
Bruno
next prev parent reply other threads:[~2010-10-22 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 19:20 [PATCH 0/5] cciss updates, PCI ID changes, kdump reset fixes Stephen M. Cameron
2010-10-22 19:21 ` [PATCH 1/5] cciss: remove controllers supported by hpsa Stephen M. Cameron
2010-10-22 19:46 ` Bruno Prémont [this message]
2010-10-22 19:21 ` [PATCH 2/5] cciss: fix board status waiting code Stephen M. Cameron
2010-10-22 19:21 ` [PATCH 3/5] cciss: Use kernel provided PCI state save and restore functions Stephen M. Cameron
2010-10-22 19:36 ` Stephen Cameron
2010-10-22 19:49 ` Jens Axboe
2010-10-22 19:21 ` [PATCH 4/5] cciss: limit commands allocated on reset_devices Stephen M. Cameron
2010-10-22 19:21 ` [PATCH 5/5] cciss: use usleep_range not msleep for small sleeps Stephen M. Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022214643.61dcafdd@neptune.home \
--to=bonbons@linux-vserver.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=smcameron@yahoo.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox