From: Arnd Bergmann <arnd@arndb.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH update] firewire: nosy: char device is not seekable
Date: Sat, 23 Oct 2010 10:57:17 +0200 [thread overview]
Message-ID: <201010231057.18135.arnd@arndb.de> (raw)
In-Reply-To: <tkrat.f853df65a5128ca0@s5r6.in-berlin.de>
On Saturday 23 October 2010, Stefan Richter wrote:
> Remove unnecessary .llseek handler that came in via an automated mass conversion.
> .llseek = NULL means no_llseek since commit 776c163b1b93.
>
> The only client that uses this interface is nosy-dump in linux/tools/firewire
> and it knows not to seek in this char dev.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> I left out the addition of return nonseekable_open(...) in nosy_open in
> this update. This works for nosy, but is it also formally correct?
>
Most likely you also want the nonseekeable_open, which would prevent
both llseek and pread/pwrite, whereas leaving out llseek currently
only prevents llseek.
Arnd
next prev parent reply other threads:[~2010-10-23 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 12:25 [PATCH] firewire: nosy: char device is not seekable Stefan Richter
2010-10-13 12:31 ` Stefan Richter
2010-10-13 13:54 ` Arnd Bergmann
2010-10-22 23:08 ` [PATCH update] " Stefan Richter
2010-10-23 8:57 ` Arnd Bergmann [this message]
2010-10-23 11:47 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010231057.18135.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox