From: Arnd Bergmann <arnd@arndb.de>
To: Alessio Igor Bogani <abogani@texware.it>
Cc: Tim Bird <tim.bird@am.sony.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] udf: Replace BKL with superblock's mutex s_lock
Date: Sat, 23 Oct 2010 13:53:12 +0200 [thread overview]
Message-ID: <201010231353.12709.arnd@arndb.de> (raw)
In-Reply-To: <1287833853-4175-1-git-send-email-abogani@texware.it>
On Saturday 23 October 2010, Alessio Igor Bogani wrote:
> This work was supported by a hardware donation from the CE Linux Forum.
>
> Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Hi Alessio,
Thanks a lot for joining in on the effort. Your patches look good for the
most part, but there are a few details you should change before they
go upstream. Most importantly, the subject lines of patches are currently
not unique and they tell very little about what is going on. You can
probably merge the three "remove BKL" patches into one and explain
why that is safe in a combined changelog.
> @@ -568,7 +568,7 @@ static int udf_remount_fs(struct super_block *sb, int *flags, char *options)
> if (!udf_parse_options(options, &uopt, true))
> return -EINVAL;
>
> - lock_kernel();
> + mutex_lock(&sb->s_lock);
> sbi->s_flags = uopt.flags;
> sbi->s_uid = uopt.uid;
> sbi->s_gid = uopt.gid;
As I recently learned, there is also an effort to get rid of sb->s_lock, so
the change in super.c is not all that helpful. When you need a per-filesystem
mutex, please instead add a new one to udf_sb_info. There is already the
s_alloc_mutex. While I haven't looked at that, maybe it can be extended to
cover the other areas that are under s_lock with your patch. Watch out for
put_super freeing sb_info under the lock though.
Arnd
prev parent reply other threads:[~2010-10-23 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 11:37 [PATCH 1/6] udf: Replace BKL with superblock's mutex s_lock Alessio Igor Bogani
2010-10-23 11:37 ` [PATCH 2/6] udf: Remove BKL Alessio Igor Bogani
2010-10-23 11:37 ` [PATCH 3/6] " Alessio Igor Bogani
2010-10-23 11:37 ` [PATCH 4/6] udf: Replace BKL Alessio Igor Bogani
2010-10-23 11:37 ` [PATCH 5/6] udf: Remove BKL Alessio Igor Bogani
2010-10-23 11:37 ` [PATCH 6/6] udf: Replace BKL Alessio Igor Bogani
2010-10-23 11:46 ` [PATCH 1/6] udf: Replace BKL with superblock's mutex s_lock Christoph Hellwig
2010-10-23 11:53 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010231353.12709.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=abogani@texware.it \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox