public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Tejun Heo <tj@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [origin tree boot failure] Re: [GIT PULL] core block bits for 2.6.37-rc1
Date: Sat, 23 Oct 2010 20:21:27 +0200	[thread overview]
Message-ID: <20101023182127.GA4160@elte.hu> (raw)
In-Reply-To: <4CC318AE.8010209@fusionio.com>


* Jens Axboe <jaxboe@fusionio.com> wrote:

> > Looks like a fairly straight forward case of uninitialized memory and 
> > blk_sync_queue() -> throtl_shutdown_timer() -> cancel_delayed_work_sync().
> > 
> > Will get that fixed up.
> 
> It frees q->td in blk_cleanup_queue(), but doesn't clear q->td. When the final put 
> happens, blk_sync_queue() is called and then ends up doing the 
> cancel_delayed_work_sync() on freed memory.
> 
> Two possible fixes:
> 
> - Clear ->td when the queue is goin dead. May require other ->td == NULL
>   checks in the code, so I opted for:
> 
> - Move the free to when the queue is really going away, post doing the
>   blk_sync_queue() call.
> 
> The below should fix it.
> 
> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>

This did the trick, thanks Jens!

Tested-by: Ingo Molnar <mingo@elte.hu>

	Ingo

  reply	other threads:[~2010-10-23 18:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22  7:57 [GIT PULL] core block bits for 2.6.37-rc1 Jens Axboe
2010-10-23 15:29 ` [origin tree boot failure] " Ingo Molnar
2010-10-23 15:42   ` Linus Torvalds
2010-10-23 15:52   ` Ingo Molnar
2010-10-23 16:51   ` Jens Axboe
2010-10-23 17:17     ` Jens Axboe
2010-10-23 18:21       ` Ingo Molnar [this message]
2010-10-23 18:43         ` [GIT PULL] Throtl bug (was Re: [origin tree boot failure] Re: [GIT PULL] core block bits for 2.6.37-rc1) Jens Axboe
2010-10-23 20:33           ` Maxim Levitsky
2010-10-24  6:15             ` Vivek Goyal
2010-10-24  5:48       ` [origin tree boot failure] Re: [GIT PULL] core block bits for 2.6.37-rc1 Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101023182127.GA4160@elte.hu \
    --to=mingo@elte.hu \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox