public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Dowland <jmtd@debian.org>
To: Matthew Garrett <mjg@redhat.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] toshiba_acpi.c: Add key_entry for a lone FN keypress
Date: Sat, 23 Oct 2010 23:12:53 +0100	[thread overview]
Message-ID: <20101023221253.GA4829@hathor> (raw)

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

A lone FN key press on a Toshiba Portégé R700 without another key in
conjunction results in an ACPI event and a spurious error message on
the console.

Add a key entry to map this event to a KEY_UNKNOWN keypress silences
this message.

Signed-off-by: Jon Dowland <jmtd@debian.org>

----

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index a388bd6..954443e 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -142,6 +142,7 @@ static struct key_entry toshiba_acpi_keymap[]  = {
 	{KE_KEY, 0x141, KEY_BRIGHTNESSUP},
 	{KE_KEY, 0x142, KEY_WLAN},
 	{KE_KEY, 0x143, KEY_PROG1},
+	{KE_KEY, 0x17f, KEY_UNKNOWN}, /* FN key by itself */
 	{KE_KEY, 0xb05, KEY_PROG2},
 	{KE_KEY, 0xb06, KEY_WWW},
 	{KE_KEY, 0xb07, KEY_MAIL},

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

             reply	other threads:[~2010-10-23 22:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-23 22:12 Jon Dowland [this message]
2010-10-25 18:27 ` [PATCH] toshiba_acpi.c: Add key_entry for a lone FN keypress Dmitry Torokhov
2010-10-25 18:42   ` Azael Avalos
2010-10-26 12:06     ` Jon Dowland
2010-10-26 12:00   ` Jon Dowland
2010-10-26 15:56     ` Dmitry Torokhov
2010-10-26 23:24       ` Jon Dowland
2010-11-24 16:48         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101023221253.GA4829@hathor \
    --to=jmtd@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox