From: Johan Hovold <jhovold@gmail.com>
To: Alon Ziv <alon+git@nolaviz.org>
Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Export usb_serial_generic_write_room for use in modules
Date: Mon, 25 Oct 2010 13:20:43 +0200 [thread overview]
Message-ID: <20101025112043.GB4046@localhost> (raw)
In-Reply-To: <1287859409-13810-2-git-send-email-alon-git@nolaviz.org>
On Sat, Oct 23, 2010 at 08:43:28PM +0200, Alon Ziv wrote:
> Any module using usb_serial_generic_write (which is already exported)
> had better use usb_serial_generic_write_room as well, or be prepared
> for failures.
As I mentioned elsewhere, this description is a little misleading as any
driver can use the generic write_room implementation simply by not
overriding it (i.e. leaving the write_room field undefined).
There is nothing wrong with exporting it, but it is currently only your
other patch that requires that. Could you perhaps just modify the patch
description?
Thanks,
Johan
next prev parent reply other threads:[~2010-10-25 11:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 18:43 [PATCH v2 0/2] Further cleanups to opticon driver Alon Ziv
2010-10-23 18:43 ` [PATCH v2 1/2] Export usb_serial_generic_write_room for use in modules Alon Ziv
2010-10-25 11:20 ` Johan Hovold [this message]
2010-10-25 19:57 ` Alon Ziv
2010-10-25 22:40 ` Johan Hovold
2010-10-23 18:43 ` [PATCH v2 2/2] opticon: use generic code where possible Alon Ziv
2010-10-25 11:11 ` Johan Hovold
2010-10-25 19:48 ` Alon Ziv
2010-11-11 16:23 ` Johan Hovold
2010-11-11 13:43 ` [PATCH v2 0/2] Further cleanups to opticon driver Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025112043.GB4046@localhost \
--to=jhovold@gmail.com \
--cc=alon+git@nolaviz.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).