From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/2] regulator: max8952 - fix max8952_set_voltage
Date: Mon, 25 Oct 2010 10:55:36 -0700 [thread overview]
Message-ID: <20101025175535.GC16246@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1287973026.23608.6.camel@mola>
On Mon, Oct 25, 2010 at 10:17:06AM +0800, Axel Lin wrote:
> In current implementation, vid is declared as u8,
> then "vid == -1" is always false, and "vid >= 0" is always true.
> Thus change it to s8.
>
> vid is always less than MAX8952_NUM_DVS_MODE in current implementation,
> thus remove the cheking for "vid < MAX8952_NUM_DVS_MODE".
This bit seems like reasonable paranoia in the face of future code
changes and we're not really in a sufficiently fast path to worry about
cycles - are you sure that this is essential?
next prev parent reply other threads:[~2010-10-25 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 2:11 [PATCH 1/2] regulator: max8952 - fix max8952_pmic_probe error path Axel Lin
2010-10-25 2:17 ` [PATCH 2/2] regulator: max8952 - fix max8952_set_voltage Axel Lin
2010-10-25 17:55 ` Mark Brown [this message]
2010-10-25 23:55 ` Axel Lin
2010-10-25 17:53 ` [PATCH 1/2] regulator: max8952 - fix max8952_pmic_probe error path Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025175535.GC16246@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox