From: Christoph Hellwig <hch@infradead.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
daniel.stodden@citrix.com, Jens Axboe <axboe@kernel.dk>,
"Theodore Ts'o" <tytso@mit.edu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] Re: linux-next regression: IO errors in with ext4 and xen-blkfront
Date: Mon, 25 Oct 2010 14:47:56 -0400 [thread overview]
Message-ID: <20101025184756.GA26230@infradead.org> (raw)
In-Reply-To: <20101025182630.GA6036@dumpdata.com>
On Mon, Oct 25, 2010 at 02:26:30PM -0400, Konrad Rzeszutek Wilk wrote:
> I think we just blindly assume that we would pass the request
> to the backend. And if the backend is running under an ancient
> version (2.6.18), the behavior would be quite different.
I don't think this has much to do with the backend. Xen never
implemented empty barriers correctly. This has been a bug since day
one, although before no one noticed because the cruft in the old
barrier code made them look like they succeed without them actually
succeeding. With the new barrier code you do get an error back for
them - and you do get them more often because cache flushes aka
empty barriers are the only thing we send now.
The right fix is to add a cache flush command to the protocol which
will do the right things for all guests. In fact I read on a netbsd
lists they had to do exactly that command to get their cache flushes
to work, so it must exist for some versions of the backends.
next prev parent reply other threads:[~2010-10-25 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 0:04 linux-next regression: IO errors in with ext4 and xen-blkfront Jeremy Fitzhardinge
2010-10-21 0:09 ` Jeremy Fitzhardinge
2010-10-22 8:18 ` Jens Axboe
2010-10-22 8:29 ` Christoph Hellwig
2010-10-22 8:54 ` Jens Axboe
2010-10-22 8:56 ` Christoph Hellwig
2010-10-22 8:57 ` Jens Axboe
2010-10-22 9:20 ` Christoph Hellwig
2010-10-25 18:26 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-10-25 18:47 ` Christoph Hellwig [this message]
2010-10-25 19:05 ` Konrad Rzeszutek Wilk
2010-10-26 12:49 ` Daniel Stodden
2010-10-27 10:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025184756.GA26230@infradead.org \
--to=hch@infradead.org \
--cc=Xen-devel@lists.xensource.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=daniel.stodden@citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox