From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sitsofe Wheeler <sitsofe@yahoo.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Len Brown <lenb@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
David Zeuthen <davidz@redhat.com>,
Richard Hughes <richard@hughsie.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / Battery: Return -ENODATA for unknown values in get_property()
Date: Mon, 25 Oct 2010 22:36:31 +0200 [thread overview]
Message-ID: <201010252236.31530.rjw@sisk.pl> (raw)
In-Reply-To: <20101025131728.GC2162@ucw.cz>
On Monday, October 25, 2010, Pavel Machek wrote:
> Hi!
>
> > That's why I suggested to use -ENODATA. :-)
> >
> > Still, if user space has problems with failing reads from the sysfs attributes,
> > it may be better to simply put -1 in there. Patch is appended, please test.
>
> I'd say that reporting -1 for unknown is ugly. You can have -1A
> current easily (charging at 1A), and I've seen machines reporting <0
> current -- when charging. Logical and well-defined.
I posted a patch fixing that in a different way (makng the battery driver return
-ENODEV instead of -ENODATA) in the meantime, which has been confirmed to work.
Thanks,
Rafael
prev parent reply other threads:[~2010-10-25 20:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 14:13 Returning ACPI_BATTERY_VALUE_UNKNOWN to userspace Sitsofe Wheeler
2010-10-16 23:05 ` [PATCH] ACPI / Battery: Return -ENODATA for unknown values in get_property() (was: Re: Returning ACPI_BATTERY ...) Rafael J. Wysocki
2010-10-17 5:19 ` Henrique de Moraes Holschuh
2010-10-17 9:59 ` [PATCH] ACPI / Battery: Return -ENODATA for unknown values in get_property() Sitsofe Wheeler
2010-10-17 13:10 ` Henrique de Moraes Holschuh
2010-10-17 14:50 ` Sitsofe Wheeler
2010-10-17 18:32 ` Rafael J. Wysocki
2010-10-21 16:54 ` Sitsofe Wheeler
2010-10-21 19:57 ` Rafael J. Wysocki
2010-10-21 20:46 ` Sitsofe Wheeler
2010-10-22 22:19 ` Rafael J. Wysocki
2010-10-23 15:36 ` Sitsofe Wheeler
2010-10-23 17:31 ` Rafael J. Wysocki
2010-10-22 12:31 ` Richard Hughes
2010-10-23 15:43 ` Sitsofe Wheeler
2010-10-25 13:17 ` Pavel Machek
2010-10-25 20:36 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010252236.31530.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=davidz@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pavel@ucw.cz \
--cc=richard@hughsie.com \
--cc=rui.zhang@intel.com \
--cc=sitsofe@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox